Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html

Issue 1858103004: bluetooth: Separate notification tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-notifications
Patch Set: Merge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found-with-uuid.html b/third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html
similarity index 60%
copy from third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found-with-uuid.html
copy to third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html
index 1f791a560992e7001c94ed8f5903df04aa762ea2..641e46fcd82e1a99d561864fecee1b4685466ee1 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found-with-uuid.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html
@@ -5,15 +5,14 @@
<script>
'use strict';
promise_test(() => {
- let expected = new DOMException(
- 'No Characteristics with specified UUID found in Service.',
- 'NotFoundError');
return setBluetoothFakeAdapter('HeartRateAdapter')
.then(() => requestDeviceWithKeyDown({
filters: [{services: ['heart_rate']}]}))
.then(device => device.gatt.connect())
.then(gattServer => gattServer.getPrimaryService('heart_rate'))
- .then(service => assert_promise_rejects_with_message(
- service.getCharacteristics('battery_level'), expected));
-}, 'Request for absent characteristics with UUID. Reject with NotFoundError.');
+ .then(service => service.getCharacteristic('heart_rate_measurement'))
+ .then(characteristic => assert_event_fires_after_promise(
+ characteristic, 'startNotifications', 'characteristicvaluechanged'));
+}, 'Starting notifications should fire an event and we should get no events ' +
+ 'after notifications are stopped.');
Jeffrey Yasskin 2016/04/15 19:56:45 I don't see the assertions for "no events after no
ortuno 2016/04/15 20:59:06 Oops, got to excited about deleting code. Done.
</script>

Powered by Google App Engine
This is Rietveld 408576698