third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html - Issue 1858103004: bluetooth: Separate notification tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html

Issue 1858103004: bluetooth: Separate notification tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-notifications

Patch Set: Merge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/notifications/concurrent-stops.html ('k') | third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 let expected = new DOMException(

9 'No Characteristics with specified UUID found in Service.',

10 'NotFoundError');

11 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

12 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

13 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

14 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

15 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

16 .then(service => assert_promise_rejects_with_message(	13 .then(service => service.getCharacteristic('heart_rate_measurement'))

17 service.getCharacteristics('battery_level'), expected));	14 .then(characteristic => assert_event_fires_after_promise(

18 }, 'Request for absent characteristics with UUID. Reject with NotFoundError.');	15 characteristic, 'startNotifications', 'characteristicvaluechanged'));

	16 }, 'Starting notifications should fire an event and we should get no events ' +

	17 'after notifications are stopped.');
	Jeffrey Yasskin 2016/04/15 19:56:45 I don't see the assertions for "no events after no I don't see the assertions for "no events after notifications are stopped." ortuno 2016/04/15 20:59:06 Oops, got to excited about deleting code. Done. Show quoted text On 2016/04/15 at 19:56:45, Jeffrey Yasskin wrote: > I don't see the assertions for "no events after notifications are stopped." Oops, got to excited about deleting code. Done.
19 </script>	18 </script>

OLD	NEW