Issue 1858103002: Strawman proposal for dealing with Android java mojo services registry in browser code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1858103002: Strawman proposal for dealing with Android java mojo services registry in browser code (Closed)

Created:
4 years, 8 months ago by ncarter (slow)

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, nhiroki, horo+watch_chromium.org, kinuko+serviceworker, darin (slow to review), tzik, ben+mojo_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Strawman proposal for how to arrange Android java mojo services registry for use by content/browser and content/public/browser. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Tweak a couple more headers. #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -21 lines)			Patch
M	content/browser/frame_host/frame_mojo_shell.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.h	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
A	content/browser/mojo/browser_service_registry_impl.h	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	content/browser/mojo/mojo_application_host.h	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	content/browser/service_worker/embedded_worker_instance.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/service_worker/embedded_worker_instance.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	content/public/browser/browser_service_registry.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/public/browser/render_frame_host.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ncarter (slow)

4 years, 8 months ago (2016-04-04 23:20:48 UTC) #1

Description was changed from

==========
Strawman proposal for how to arrange Android java mojo services registry for use
by content/browser and content/public/browser.

BUG=
==========

to

==========
Strawman proposal for how to arrange Android java mojo services registry for use
by content/browser and content/public/browser.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages