third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console Base URL: https://chromium.googlesource.com/chromium/src.git@fix_472253_1

Patch Set: Rebase to ToT and Update layout test expectations to include the new console logs Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/media-reparent.html ('K') | « third_party/WebKit/LayoutTests/permissionclient/video-permissions-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index a90d46750ed94108f3485e12de823c6ced35d227..4fa8f8816f25f510cd52b2568729a899f1166c84 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -375,6 +375,7 @@ private:

void clearMediaPlayer();

void clearMediaPlayerAndAudioSourceProviderClientWithoutLocking();

bool havePotentialSourceChild();

+ void reportPlayerErrorToDevToolsConsole();

void noneSupported();

void mediaEngineError(MediaError*);

void cancelPendingEventsAndCallbacks();