third_party/WebKit/LayoutTests/media/media-reparent.html - Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/media-reparent.html

Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console Base URL: https://chromium.googlesource.com/chromium/src.git@fix_472253_1

Patch Set: Rebase to ToT and Update layout test expectations to include the new console logs Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/media-controls-invalid-url-expected.txt ('k') | third_party/WebKit/LayoutTests/media/media-reparent-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/media-reparent.html

diff --git a/third_party/WebKit/LayoutTests/media/media-reparent.html b/third_party/WebKit/LayoutTests/media/media-reparent.html

index 59a6c811b05c0350f2d59644173f4a3d7563b917..5ccb7ce1d712c35ae7287d6de7adb68340f53f23 100644

--- a/third_party/WebKit/LayoutTests/media/media-reparent.html

+++ b/third_party/WebKit/LayoutTests/media/media-reparent.html

@@ -8,10 +8,17 @@ setTimeout(function(){

document.documentElement.appendChild(f);

var w = f.contentWindow;

var div = w.document.createElement('div');

- div.innerHTML = '<audio src="1">';

+ div.innerHTML = '<audio src="1">'; // Attempt to load this URL should fail.

var node = div;

f.parentNode.removeChild(f);

document.body.appendChild(node);

- endTestLater();

+ // TODO(wolenetz,philipj): Avoid large timeout here by using

+ // waitForEventAndEnd('error') once that error event is reliably

+ // deliverable to the new parent. See https://crbug.com/600849.

+ // Larger than 250ms endTestLater() timeout is used here to prevent

+ // flakily missing console error log. If flakes recur, we may needxi

philipj_slow 2016/04/06 09:05:37 s/needxi/need/

wolenetz 2016/04/06 20:16:04 Done :)

+ // to increase it further.

+ setTimeout(endTest, 750);

})

</script>