Cleanup the FF Handler proxy methods.

Cleanup the FF Handler proxy methods.

This CL removes the proxy methods from CXFA_FFWidgetHandler and CXFA_DocHandler
and removes CXFA_FFMenuHandler as it was only proxy methods.

The calls are made directly on the object now.

Committed: https://pdfium.googlesource.com/pdfium/+/221caf6f6f9810cbc0e0c4c50af9b036a052ae13

[dsinclair, 2016-04-04 18:24:15]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-04 18:24:16]

PTAL.

This is fallout from removing the IXFA_* types. These proxy methods were just
used to cast to the concrete versions.

[Tom Sepez, 2016-04-04 18:33:11]

lgtm

https://codereview.chromium.org/1857893002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1857893002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:485: if (!pEnv)
nit: return pEnv && pEnv->FFI_PopupMenu(....);

[dsinclair, 2016-04-04 18:43:02]

https://codereview.chromium.org/1857893002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1857893002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:485: if (!pEnv)
On 2016/04/04 18:33:10, Tom Sepez wrote:
> nit: return pEnv && pEnv->FFI_PopupMenu(....);

Done.

[dsinclair, 2016-04-04 18:43:08]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-04 18:43:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1857893002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-04 18:43:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857893002/20001

[commit-bot: I haz the power, 2016-04-04 19:08:42]

Description was changed from

==========
Cleanup the FF Handler proxy methods.

This CL removes the proxy methods from CXFA_FFWidgetHandler and CXFA_DocHandler
and removes CXFA_FFMenuHandler as it was only proxy methods.

The calls are made directly on the object now.
==========

to

==========
Cleanup the FF Handler proxy methods.

This CL removes the proxy methods from CXFA_FFWidgetHandler and CXFA_DocHandler
and removes CXFA_FFMenuHandler as it was only proxy methods.

The calls are made directly on the object now.

Committed:
https://pdfium.googlesource.com/pdfium/+/221caf6f6f9810cbc0e0c4c50af9b036a052...
==========

[commit-bot: I haz the power, 2016-04-04 19:08:44]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/221caf6f6f9810cbc0e0c4c50af9b036a052...