Cleanup the FF Handler proxy methods.

fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_stream_acc.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_string.h"
 #include "fpdfsdk/include/fpdfxfa/fpdfxfa_app.h"
 #include "fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h"
 #include "fpdfsdk/include/fpdfxfa/fpdfxfa_page.h"
 #include "fpdfsdk/include/fpdfxfa/fpdfxfa_util.h"
 #include "fpdfsdk/include/fsdk_define.h"
 #include "fpdfsdk/include/fsdk_mgr.h"
 #include "fpdfsdk/javascript/ijs_runtime.h"
 #include "public/fpdf_formfill.h"
 #include "xfa/include/fxfa/xfa_ffapp.h"
 #include "xfa/include/fxfa/xfa_ffdoc.h"
 #include "xfa/include/fxfa/xfa_ffdocview.h"
 #include "xfa/include/fxfa/xfa_ffpageview.h"
+#include "xfa/include/fxfa/xfa_ffwidget.h"
 
 #define IDS_XFA_Validate_Input                                          \
   "At least one required field was empty. Please fill in the required " \
   "fields\r\n(highlighted) before continuing."
 
 // submit
 #define FXFA_CONFIG 0x00000001
 #define FXFA_TEMPLATE 0x00000010
 #define FXFA_LOCALESET 0x00000100
 #define FXFA_DATASETS 0x00001000
@@ skipping 64 matching lines @@
     SetLastError(FPDF_ERR_XFALOAD);
     return FALSE;
   }
 
   CXFA_FFDocHandler* pDocHandler = pApp->GetDocHandler();
   if (!pDocHandler) {
     SetLastError(FPDF_ERR_XFALOAD);
     return FALSE;
   }
 
-  pDocHandler->StartLoad(m_pXFADoc);
-  int iStatus = pDocHandler->DoLoad(m_pXFADoc, NULL);
+  m_pXFADoc->StartLoad();
+  int iStatus = m_pXFADoc->DoLoad(nullptr);
   if (iStatus != XFA_PARSESTATUS_Done) {
     CloseXFADoc(pDocHandler);
     SetLastError(FPDF_ERR_XFALOAD);
     return FALSE;
   }
-  pDocHandler->StopLoad(m_pXFADoc);
-  pDocHandler->SetJSERuntime(m_pXFADoc, m_pApp->GetJSERuntime());
+  m_pXFADoc->StopLoad();
+  m_pXFADoc->GetXFADoc()->InitScriptContext(m_pApp->GetJSERuntime());
 
-  if (pDocHandler->GetDocType(m_pXFADoc) == XFA_DOCTYPE_Dynamic)
+  if (m_pXFADoc->GetDocType() == XFA_DOCTYPE_Dynamic)
     m_iDocType = DOCTYPE_DYNAMIC_XFA;
   else
     m_iDocType = DOCTYPE_STATIC_XFA;
 
-  m_pXFADocView = pDocHandler->CreateDocView(m_pXFADoc, XFA_DOCVIEW_View);
+  m_pXFADocView = m_pXFADoc->CreateDocView(XFA_DOCVIEW_View);
   if (m_pXFADocView->StartLayout() < 0) {
     CloseXFADoc(pDocHandler);
     SetLastError(FPDF_ERR_XFALAYOUT);
     return FALSE;
   }
 
   m_pXFADocView->DoLayout(NULL);
   m_pXFADocView->StopLayout();
   m_nLoadStatus = FXFA_LOADSTATUS_LOADED;
 
@@ skipping 135 matching lines @@
   if (!m_pXFADoc || !m_pSDKDoc || !m_pXFADocView)
     return;
 
   if (m_iDocType != DOCTYPE_DYNAMIC_XFA)
     return;
 
   CXFA_FFWidgetHandler* pWidgetHandler = m_pXFADocView->GetWidgetHandler();
   if (!pWidgetHandler)
     return;
 
-  CXFA_FFPageView* pPageView = pWidgetHandler->GetPageView(hWidget);
+  CXFA_FFPageView* pPageView = hWidget->GetPageView();
   if (!pPageView)
     return;
 
   CFX_RectF rect;
-  pWidgetHandler->GetRect(hWidget, rect);
+  hWidget->GetRect(rect);
   InvalidateRect(pPageView, rect, dwFlags);
 }
 
 void CPDFXFA_Document::DisplayCaret(CXFA_FFWidget* hWidget,
                                     FX_BOOL bVisible,
                                     const CFX_RectF* pRtAnchor) {
   if (!hWidget || pRtAnchor == NULL)
     return;
 
   if (!m_pXFADoc || !m_pSDKDoc || !m_pXFADocView)
     return;
 
   if (m_iDocType != DOCTYPE_DYNAMIC_XFA)
     return;
 
   CXFA_FFWidgetHandler* pWidgetHandler = m_pXFADocView->GetWidgetHandler();
   if (!pWidgetHandler)
     return;
 
-  CXFA_FFPageView* pPageView = pWidgetHandler->GetPageView(hWidget);
+  CXFA_FFPageView* pPageView = hWidget->GetPageView();
   if (!pPageView)
     return;
 
   CPDFXFA_Page* pPage = GetPage(pPageView);
 
   if (pPage == NULL)
     return;
 
   CFX_FloatRect rcCaret;
   FXRect2PDFRect(*pRtAnchor, rcCaret);
 
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
   if (!pEnv)
     return;
 
   pEnv->FFI_DisplayCaret((FPDF_PAGE)pPage, bVisible, rcCaret.left, rcCaret.top,
                          rcCaret.right, rcCaret.bottom);
 }
 
 FX_BOOL CPDFXFA_Document::GetPopupPos(CXFA_FFWidget* hWidget,
                                       FX_FLOAT fMinPopup,
                                       FX_FLOAT fMaxPopup,
                                       const CFX_RectF& rtAnchor,
                                       CFX_RectF& rtPopup) {
-  if (NULL == hWidget) {
-    return FALSE;
-  }
-  CXFA_FFPageView* pXFAPageView =
-      m_pXFADocView->GetWidgetHandler()->GetPageView(hWidget);
-  if (NULL == pXFAPageView) {
-    return FALSE;
-  }
-  CPDFXFA_Page* pPage = GetPage(pXFAPageView);
-  if (pPage == NULL)
+  if (!hWidget)
     return FALSE;
 
-  CXFA_WidgetAcc* pWidgetAcc =
-      m_pXFADocView->GetWidgetHandler()->GetDataAcc(hWidget);
+  CXFA_FFPageView* pXFAPageView = hWidget->GetPageView();
+  if (!pXFAPageView)
+    return FALSE;
 
+  CPDFXFA_Page* pPage = GetPage(pXFAPageView);
+  if (!pPage)
+    return FALSE;
+
+  CXFA_WidgetAcc* pWidgetAcc = hWidget->GetDataAcc();
   int nRotate = 0;
 #ifdef PDF_ENABLE_XFA
   nRotate = pWidgetAcc->GetRotate();
 #endif
 
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
-  if (pEnv == NULL)
+  if (!pEnv)
     return FALSE;
   FS_RECTF pageViewRect;
   pEnv->FFI_GetPageViewRect(pPage, pageViewRect);
 
   CFX_FloatRect rcAnchor;
 
   rcAnchor.left = rtAnchor.left;
   rcAnchor.top = rtAnchor.bottom();
   rcAnchor.right = rtAnchor.right();
   rcAnchor.bottom = rtAnchor.top;
@@ skipping 90 matching lines @@
     default:
       break;
   }
 
   return TRUE;
 }
 
 FX_BOOL CPDFXFA_Document::PopupMenu(CXFA_FFWidget* hWidget,
                                     CFX_PointF ptPopup,
                                     const CFX_RectF* pRectExclude) {
-  if (NULL == hWidget) {
+  if (!hWidget)
     return FALSE;
-  }
-  CXFA_FFPageView* pXFAPageView =
-      m_pXFADocView->GetWidgetHandler()->GetPageView(hWidget);
-  if (pXFAPageView == NULL)
+
+  CXFA_FFPageView* pXFAPageView = hWidget->GetPageView();
+  if (!pXFAPageView)
     return FALSE;
+
   CPDFXFA_Page* pPage = GetPage(pXFAPageView);
-
-  if (pPage == NULL)
+  if (!pPage)
     return FALSE;
 
   int menuFlag = 0;
 
-  CXFA_FFMenuHandler* pXFAMenuHander = m_pApp->GetXFAApp()->GetMenuHandler();
-  if (pXFAMenuHander->CanUndo(hWidget))
+  if (hWidget->CanUndo())
     menuFlag |= FXFA_MEMU_UNDO;
-  if (pXFAMenuHander->CanRedo(hWidget))
+  if (hWidget->CanRedo())
     menuFlag |= FXFA_MEMU_REDO;
-  if (pXFAMenuHander->CanPaste(hWidget))
+  if (hWidget->CanPaste())
     menuFlag |= FXFA_MEMU_PASTE;
-  if (pXFAMenuHander->CanCopy(hWidget))
+  if (hWidget->CanCopy())
     menuFlag |= FXFA_MEMU_COPY;
-  if (pXFAMenuHander->CanCut(hWidget))
+  if (hWidget->CanCut())
     menuFlag |= FXFA_MEMU_CUT;
-  if (pXFAMenuHander->CanSelectAll(hWidget))
+  if (hWidget->CanSelectAll())
     menuFlag |= FXFA_MEMU_SELECTALL;
 
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
-  if (pEnv == NULL)
-    return FALSE;
-
-  return pEnv->FFI_PopupMenu(pPage, hWidget, menuFlag, ptPopup, NULL);
+  return pEnv && pEnv->FFI_PopupMenu(pPage, hWidget, menuFlag, ptPopup, NULL);
 }
 
 void CPDFXFA_Document::PageViewEvent(CXFA_FFPageView* pPageView,
                                      uint32_t dwFlags) {
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
   if (!pEnv)
     return;
 
   if (m_nLoadStatus != FXFA_LOADSTATUS_LOADING &&
       m_nLoadStatus != FXFA_LOADSTATUS_CLOSING &&
@@ skipping 30 matching lines @@
                                    uint32_t dwEvent,
                                    void* pParam,
                                    void* pAdditional) {
   if (m_iDocType != DOCTYPE_DYNAMIC_XFA || !hWidget)
     return;
 
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
   if (!pEnv)
     return;
 
-  CXFA_FFPageView* pPageView =
-      m_pXFADocView->GetWidgetHandler()->GetPageView(hWidget);
-  if (pPageView == NULL)
+  CXFA_FFPageView* pPageView = hWidget->GetPageView();
+  if (!pPageView)
     return;
 
   CPDFXFA_Page* pXFAPage = GetPage(pPageView);
-  if (pXFAPage == NULL)
+  if (!pXFAPage)
     return;
 
   CPDFSDK_PageView* pSdkPageView = m_pSDKDoc->GetPageView(pXFAPage);
   if (dwEvent == XFA_WIDGETEVENT_PostAdded) {
     pSdkPageView->AddAnnot(hWidget);
-
   } else if (dwEvent == XFA_WIDGETEVENT_PreRemoved) {
     CPDFSDK_Annot* pAnnot = pSdkPageView->GetAnnotByXFAWidget(hWidget);
-    if (pAnnot) {
+    if (pAnnot)
       pSdkPageView->DeleteAnnot(pAnnot);
-    }
   }
 }
 
 int32_t CPDFXFA_Document::CountPages(CXFA_FFDoc* hDoc) {
-  if (hDoc == m_pXFADoc && m_pSDKDoc) {
+  if (hDoc == m_pXFADoc && m_pSDKDoc)
     return GetPageCount();
-  }
   return 0;
 }
+
 int32_t CPDFXFA_Document::GetCurrentPage(CXFA_FFDoc* hDoc) {
   if (hDoc != m_pXFADoc || !m_pSDKDoc)
     return -1;
   if (m_iDocType != DOCTYPE_DYNAMIC_XFA)
     return -1;
 
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
-  if (pEnv == NULL)
+  if (!pEnv)
     return -1;
 
   return pEnv->FFI_GetCurrentPageIndex(this);
 }
+
 void CPDFXFA_Document::SetCurrentPage(CXFA_FFDoc* hDoc, int32_t iCurPage) {
   if (hDoc != m_pXFADoc || !m_pSDKDoc || m_iDocType != DOCTYPE_DYNAMIC_XFA ||
       iCurPage < 0 || iCurPage >= m_pSDKDoc->GetPageCount()) {
     return;
   }
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
   if (!pEnv)
     return;
   pEnv->FFI_SetCurrentPage(this, iCurPage);
 }
@@ skipping 63 matching lines @@
   FPDF_FILEHANDLER* pFileHandler = pEnv->FFI_OpenFile(
       bXDP ? FXFA_SAVEAS_XDP : FXFA_SAVEAS_XML,
       (FPDF_WIDESTRING)bs.GetBuffer(len * sizeof(unsigned short)), "wb");
   bs.ReleaseBuffer(len * sizeof(unsigned short));
 
   if (pFileHandler == NULL)
     return;
 
   CFPDF_FileStream fileWrite(pFileHandler);
 
-  CXFA_FFDocHandler* pXFADocHander = m_pApp->GetXFAApp()->GetDocHandler();
   CFX_ByteString content;
   if (fileType == FXFA_SAVEAS_XML) {
     content = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n";
     fileWrite.WriteBlock((const FX_CHAR*)content, fileWrite.GetSize(),
                          content.GetLength());
     CFX_WideStringC data(L"data");
-    if (pXFADocHander->SavePackage(m_pXFADocView->GetDoc(), data, &fileWrite)) {
+    if (m_pXFADocView->GetDoc()->SavePackage(data, &fileWrite)) {
       // Ignoring error.
     }
   } else if (fileType == FXFA_SAVEAS_XDP) {
     if (m_pPDFDoc == NULL)
       return;
     CPDF_Dictionary* pRoot = m_pPDFDoc->GetRoot();
     if (pRoot == NULL)
       return;
     CPDF_Dictionary* pAcroForm = pRoot->GetDictBy("AcroForm");
     if (NULL == pAcroForm)
@@ skipping 12 matching lines @@
       CPDF_Object* pPrePDFObj = pArray->GetObjectAt(i - 1);
       if (!pPrePDFObj->IsString())
         continue;
       if (!pPDFObj->IsReference())
         continue;
       CPDF_Object* pDirectObj = pPDFObj->GetDirect();
       if (!pDirectObj->IsStream())
         continue;
       if (pPrePDFObj->GetString() == "form") {
         CFX_WideStringC form(L"form");
-        pXFADocHander->SavePackage(m_pXFADocView->GetDoc(), form, &fileWrite);
+        m_pXFADocView->GetDoc()->SavePackage(form, &fileWrite);
       } else if (pPrePDFObj->GetString() == "datasets") {
         CFX_WideStringC datasets(L"datasets");
-        pXFADocHander->SavePackage(m_pXFADocView->GetDoc(), datasets,
-                                   &fileWrite);
+        m_pXFADocView->GetDoc()->SavePackage(datasets, &fileWrite);
       } else {
         if (i == size - 1) {
           CFX_WideString wPath = CFX_WideString::FromUTF16LE(
               (unsigned short*)(const FX_CHAR*)bs,
               bs.GetLength() / sizeof(unsigned short));
           CFX_ByteString bPath = wPath.UTF8Encode();
           CFX_ByteString szFormat =
               "\n<pdf href=\"%s\" xmlns=\"http://ns.adobe.com/xdp/pdf/\"/>";
           content.Format(szFormat, (char*)(const FX_CHAR*)bPath);
           fileWrite.WriteBlock((const FX_CHAR*)content, fileWrite.GetSize(),
@@ skipping 226 matching lines @@
   bs.ReleaseBuffer(len * sizeof(unsigned short));
 
   if (pFileHandler == NULL)
     return NULL;
   return new CFPDF_FileStream(pFileHandler);
 }
 FX_BOOL CPDFXFA_Document::_ExportSubmitFile(FPDF_FILEHANDLER* pFileHandler,
                                             int fileType,
                                             FPDF_DWORD encodeType,
                                             FPDF_DWORD flag) {
-  if (NULL == m_pXFADocView)
+  if (!m_pXFADocView)
     return FALSE;
-  CXFA_FFDocHandler* pDocHandler = m_pApp->GetXFAApp()->GetDocHandler();
+
   CFX_ByteString content;
-
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
-  if (pEnv == NULL)
+  if (!pEnv)
     return FALSE;
 
   CFPDF_FileStream fileStream(pFileHandler);
 
   if (fileType == FXFA_SAVEAS_XML) {
     CFX_WideString ws;
     ws.FromLocal("data");
     CFX_ByteString content = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n";
     fileStream.WriteBlock((const FX_CHAR*)content, 0, content.GetLength());
-    pDocHandler->SavePackage(m_pXFADoc, ws, &fileStream);
+    m_pXFADoc->SavePackage(ws, &fileStream);
   } else if (fileType == FXFA_SAVEAS_XDP) {
     if (flag == 0)
       flag = FXFA_CONFIG | FXFA_TEMPLATE | FXFA_LOCALESET | FXFA_DATASETS |
              FXFA_XMPMETA | FXFA_XFDF | FXFA_FORM;
     if (m_pPDFDoc == NULL) {
       fileStream.Flush();
       return FALSE;
     }
     CPDF_Dictionary* pRoot = m_pPDFDoc->GetRoot();
     if (pRoot == NULL) {
@@ skipping 40 matching lines @@
         continue;
       if (pPrePDFObj->GetString() == "xmpmeta" && !(flag & FXFA_XMPMETA))
         continue;
       if (pPrePDFObj->GetString() == "xfdf" && !(flag & FXFA_XFDF))
         continue;
       if (pPrePDFObj->GetString() == "form" && !(flag & FXFA_FORM))
         continue;
       if (pPrePDFObj->GetString() == "form") {
         CFX_WideString ws;
         ws.FromLocal("form");
-        pDocHandler->SavePackage(m_pXFADoc, ws, &fileStream);
+        m_pXFADoc->SavePackage(ws, &fileStream);
       } else if (pPrePDFObj->GetString() == "datasets") {
         CFX_WideString ws;
         ws.FromLocal("datasets");
-        pDocHandler->SavePackage(m_pXFADoc, ws, &fileStream);
+        m_pXFADoc->SavePackage(ws, &fileStream);
       } else {
         // PDF,creator.
       }
     }
   }
   return TRUE;
 }
 
 void CPDFXFA_Document::_ClearChangeMark() {
   if (m_pSDKDoc)
@@ skipping 236 matching lines @@
   }
 
   return _GetHValueByName(szPropName, hValue,
                           m_pSDKDoc->GetEnv()->GetJSRuntime());
 }
 FX_BOOL CPDFXFA_Document::_GetHValueByName(const CFX_ByteStringC& utf8Name,
                                            FXJSE_HVALUE hValue,
                                            IJS_Runtime* runTime) {
   return runTime->GetHValueByName(utf8Name, hValue);
 }