Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1857723002: Fetch: opaque redirect responses have a URL. (Closed)

Created:
4 years, 8 months ago by Mike West
Modified:
4 years, 8 months ago
Reviewers:
horo
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch: opaque redirect responses have a URL. Tiny bug fix, extracted from https://codereview.chromium.org/1844053003. Opaque redirect responses maintain their url list, which is safe to do because the redirect never actually happens. R=horo@chromium.org Committed: https://crrev.com/88f080c222754f5dd5ad5759efb25ea005ee30ca Cr-Commit-Position: refs/heads/master@{#385109}

Patch Set 1 #

Patch Set 2 : this. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp View 1 2 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Mike West
Extracting this from the other CL to reduce the number of moving parts. :) WDYT?
4 years, 8 months ago (2016-04-04 09:42:44 UTC) #1
Mike West
Ping?
4 years, 8 months ago (2016-04-05 04:12:05 UTC) #2
horo
lgtm
4 years, 8 months ago (2016-04-05 04:24:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857723002/20001
4 years, 8 months ago (2016-04-05 05:32:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 05:38:33 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 05:39:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88f080c222754f5dd5ad5759efb25ea005ee30ca
Cr-Commit-Position: refs/heads/master@{#385109}

Powered by Google App Engine
This is Rietveld 408576698