appengine/tsmon/standardmetrics_test.go - Issue 1857643003: Revert of Migrate tsmon protos to proto3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/tsmon/standardmetrics_test.go

Issue 1857643003: Revert of Migrate tsmon protos to proto3 (Closed) Base URL: git@github.com:luci/luci-go.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/tsmon/standardmetrics_test.go

diff --git a/appengine/tsmon/standardmetrics_test.go b/appengine/tsmon/standardmetrics_test.go

index 41d39587a695e2cd2f4562f9f9269bfaf51d6c5a..169d5f30f602727f71682de631999136cb9e420b 100644

--- a/appengine/tsmon/standardmetrics_test.go

+++ b/appengine/tsmon/standardmetrics_test.go

@@ -7,6 +7,7 @@

import (

"testing"

+ "github.com/golang/protobuf/proto"

"github.com/luci/luci-go/common/tsmon"

"github.com/luci/luci-go/common/tsmon/monitor"

"github.com/luci/luci-go/common/tsmon/store"

@@ -18,7 +19,7 @@

func TestStandardMetrics(t *testing.T) {

Convey("Default version", t, func() {

c, _ := buildGAETestContext()

- tsmon.GetState(c).S = store.NewInMemory(&target.Task{ServiceName: "default target"})

+ tsmon.GetState(c).S = store.NewInMemory(&target.Task{ServiceName: proto.String("default target")})

standardMetricsCallback(c)

tsmon.Flush(c)

« no previous file with comments | « appengine/tsmon/middleware_test.go ('k') | common/tsmon/context.go » ('j') | no next file with comments »