Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857623003: convert //mash to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert //mash to std::unique_ptr BUG=554298 Committed: https://crrev.com/1aaf50682f5b06bea8db36316dcddde48444b54e Cr-Commit-Position: refs/heads/master@{#384948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -72 lines) Patch
M mash/browser_driver/browser_driver_application_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/common/mus_views_init.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/init/init.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/init/init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/login/login.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/session/session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/session/session.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mash/wm/accelerator_registrar_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mash/wm/frame/caption_buttons/frame_caption_button.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/wm/frame/caption_buttons/frame_caption_button_container_view.h View 2 chunks +2 lines, -1 line 0 comments Download
M mash/wm/frame/default_header_painter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/wm/frame/move_event_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mash/wm/frame/move_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/frame/move_loop.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mash/wm/frame/move_loop.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mash/wm/frame/move_loop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.h View 1 chunk +0 lines, -1 line 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mash/wm/layout_manager_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mash/wm/root_window_controller.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mash/wm/shadow.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mash/wm/user_window_controller_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M mash/wm/window_manager.h View 2 chunks +6 lines, -3 lines 0 comments Download
M mash/wm/window_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mash/wm/window_manager_application.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mash/wm/window_manager_application.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mash/wm/window_manager_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857623003/1
4 years, 8 months ago (2016-04-03 19:17:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 19:48:27 UTC) #4
Mostyn Bramley-Moore
@Elliot: please take a look.
4 years, 8 months ago (2016-04-03 20:01:11 UTC) #6
Elliot Glaysher
lgtm
4 years, 8 months ago (2016-04-04 17:15:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857623003/1
4 years, 8 months ago (2016-04-04 17:17:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 17:56:35 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 17:57:45 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1aaf50682f5b06bea8db36316dcddde48444b54e
Cr-Commit-Position: refs/heads/master@{#384948}

Powered by Google App Engine
This is Rietveld 408576698