Update code so 1:1 relation between delegate and router is more clear.

Update code so 1:1 relation between delegate and router is more clear.

Removed the list of delegates and extraneous code around that. Updated
tests to match.

BUG=598826
Committed: https://crrev.com/b6770b9db207252850b2cac03bec14a327939fa0
Cr-Commit-Position: refs/heads/master@{#387406}

[hcarmona, 2016-04-02 01:40:39]

hcarmona@chromium.org changed reviewers:
+ stevenjb@chromium.org

[hcarmona, 2016-04-02 01:40:40]

PTAL

Thanks!

[stevenjb, 2016-04-06 00:17:08]

Thanks for doing this cleanup!

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
(right):

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h:42:
virtual void SendPasswordExceptionsList() = 0;
These should be commented here.

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h
(right):

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h:37:
const std::string& plaintext_password);
These should be commented.

[hcarmona, 2016-04-06 01:51:23]

Added comments.

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
(right):

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h:42:
virtual void SendPasswordExceptionsList() = 0;
On 2016/04/06 00:17:08, stevenjb wrote:
> These should be commented here.

Done.

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h
(right):

https://codereview.chromium.org/1857513002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h:37:
const std::string& plaintext_password);
On 2016/04/06 00:17:08, stevenjb wrote:
> These should be commented.

Done.

[stevenjb, 2016-04-06 17:19:30]

lgtm

[hcarmona, 2016-04-14 19:43:18]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-04-14 19:43:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857513002/20001

[commit-bot: I haz the power, 2016-04-14 20:26:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 20:27:18]

Description was changed from

==========
Update code so 1:1 relation between delegate and router is more clear.

Removed the list of delegates and extraneous code around that. Updated
tests to match.

BUG=598826
==========

to

==========
Update code so 1:1 relation between delegate and router is more clear.

Removed the list of delegates and extraneous code around that. Updated
tests to match.

BUG=598826

Committed: https://crrev.com/b6770b9db207252850b2cac03bec14a327939fa0
Cr-Commit-Position: refs/heads/master@{#387406}
==========

[commit-bot: I haz the power, 2016-04-14 20:27:19]

Patchset 2 (id:??) landed as
https://crrev.com/b6770b9db207252850b2cac03bec14a327939fa0
Cr-Commit-Position: refs/heads/master@{#387406}