chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h - Issue 1857513002: Update code so 1:1 relation between delegate and router is more clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

Issue 1857513002: Update code so 1:1 relation between delegate and router is more clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

index b2cf817fd0256e1da8f43cbef4f20ccd027a1ec4..b9174036092af9a9938c19bddd37acf1b3c63751 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

@@ -39,8 +39,8 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,

~PasswordsPrivateDelegateImpl() override;

// PasswordsPrivateDelegate implementation.

- void AddObserver(Observer* observer) override;

- void RemoveObserver(Observer* observer) override;

+ void SendSavedPasswordsList() override;

+ void SendPasswordExceptionsList() override;

void RemoveSavedPassword(

const std::string& origin_url, const std::string& username) override;

void RemovePasswordException(const std::string& exception_url) override;

@@ -83,8 +83,6 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,

void RequestShowPasswordInternal(const std::string& origin_url,

const std::string& username,

content::WebContents* web_contents);

- void SendSavedPasswordsList();

- void SendPasswordExceptionsList();

// Not owned by this class.

Profile* profile_;

@@ -117,9 +115,6 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,

// NativeWindow for the window where the API was called.

content::WebContents* web_contents_;

- // The observers.

- base::ObserverList<Observer> observers_;

// Map from origin URL and username to the index of |password_list_| at which

// the corresponding entry resides.

std::map<std::string, size_t> login_pair_to_index_map_;