tools/metrics/histograms/histograms.xml - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: No need to add Default group to variation config Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/page_load_metrics/renderer/page_timing_metrics_sender.cc ('K') | « components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index cdd10ea8eb07cf55622420a694e0131d6e2f92e8..518bcd18b3202aa0f579a6618f31e5d84a3071ca 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -34566,6 +34566,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PageLoad.Timing2.ParseStartToFirstContentfulPaint" units="ms">

+ <owner>bmcquade@chromium.org</owner>

+ <owner>csharrison@chromium.org</owner>

+ <summary>

+ Measures the time from when the HTML parser started, to when the page first

+ paints content.

+ </summary>

+</histogram>

<owner>haraken@chromium.org</owner>

@@ -90261,6 +90270,9 @@ To add a new entry, add it with any value and run test to compute valid value.

<suffix name="Clients.FromGWS"

label="PageLoadMetrics that are a result of a navigation from a Google

web search"/>

+ <suffix name="Clients.DocWrite.Evaluator"

+ label="PageLoadMetrics from a page that could have been evaluated by

+ the DocumentWriteEvaluator"/>

<affected-histogram

name="PageLoad.Timing2.DOMLoadingToDOMContentLoadedEventFired"/>

<affected-histogram name="PageLoad.Timing2.DOMLoadingToFirstContentfulPaint"/>

@@ -90272,6 +90284,11 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="PageLoad.Timing2.NavigationToFirstPaint"/>

<affected-histogram name="PageLoad.Timing2.NavigationToFirstTextPaint"/>

<affected-histogram name="PageLoad.Timing2.NavigationToLoadEventFired"/>

+ <affected-histogram name="PageLoad.Timing2.ParseBlockedOnScriptLoad"/>

+ <affected-histogram

+ name="PageLoad.Timing2.ParseBlockedOnScriptLoad.ParseComplete"/>

+ <affected-histogram name="PageLoad.Timing2.ParseDuration"/>

+ <affected-histogram name="PageLoad.Timing2.ParseStartToFirstContentfulPaint"/>

</histogram_suffixes>

<histogram_suffixes name="PageLoadType">