Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1857413002: Remove now-unnecessary dbghelp.dll suitable for XP (Closed)

Created:
4 years, 8 months ago by scottmg
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now-unnecessary dbghelp.dll suitable for XP I added this in https://bugs.chromium.org/p/chromium/issues/detail?id=460506. I believe it to be unnecessary now. This is not a shipped DLL, it's only in the output dir for bots. R=mark@chromium.org BUG=579196 Committed: https://crrev.com/cef76b58729443b9fa1c3b1cfa03be50694d20f8 Cr-Commit-Position: refs/heads/master@{#385356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M base/base.isolate View 1 chunk +0 lines, -8 lines 0 comments Download
D build/win/dbghelp_xp/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
D build/win/dbghelp_xp/dbghelp.dll View Binary file 0 comments Download

Messages

Total messages: 14 (7 generated)
scottmg
4 years, 8 months ago (2016-04-05 23:45:03 UTC) #5
scottmg
+kbr fyi
4 years, 8 months ago (2016-04-05 23:45:28 UTC) #6
Mark Mentovai
LGTM
4 years, 8 months ago (2016-04-05 23:50:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857413002/1
4 years, 8 months ago (2016-04-05 23:53:13 UTC) #9
Ken Russell (switch to Gerrit)
Thanks for the CC:. Let's also close http://crbug.com/460506 and http://crbug.com/461160 ?
4 years, 8 months ago (2016-04-05 23:53:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 01:07:17 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 01:08:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cef76b58729443b9fa1c3b1cfa03be50694d20f8
Cr-Commit-Position: refs/heads/master@{#385356}

Powered by Google App Engine
This is Rietveld 408576698