Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: base/BUILD.gn

Issue 1857413002: Remove now-unnecessary dbghelp.dll suitable for XP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 0a0a6497b78edf8ec420649edeba1b6f721a917d..08dd0cda8ac7257b70a61fdda0266f777e5db823 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -65,15 +65,6 @@ if (is_win) {
"/DELAYLOAD:setupapi.dll",
]
}
-
- copy("copy_dbghelp.dll") {
- sources = [
- "../build/win/dbghelp_xp/dbghelp.dll",
- ]
- outputs = [
- "$root_out_dir/{{source_file_part}}",
- ]
- }
}
if (is_nacl_nonsfi) {
@@ -1169,13 +1160,7 @@ component("base") {
"sha1_win.cc",
]
- # Required for base/stack_trace_win.cc to symbolize correctly.
- data += [ "$root_build_dir/dbghelp.dll" ]
-
deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ]
- if (current_toolchain == default_toolchain) {
- deps += [ ":copy_dbghelp.dll" ]
- }
if (is_component_build) {
# Copy the VS runtime DLLs into the isolate so that they don't have to be
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698