Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1857393002: Remove page visibility requirement for WebUSB. (Closed)

Created:
4 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
juncai
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@usb_indicator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove page visibility requirement for WebUSB. Now that there is a tab indicator for WebUSB it can be used from a tab that is not in the foreground. BUG=595375, 592105 Committed: https://crrev.com/4c3ab3d07108f906137537c771de9b5bda0ef83c Cr-Commit-Position: refs/heads/master@{#386221}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -120 lines) Patch
D third_party/WebKit/LayoutTests/usb/disconnect-when-hidden-or-closed.html View 1 chunk +0 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 7 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Reilly Grant (use Gerrit)
Please take a look. I'll wait until https://codereview.chromium.org/1857033003/ lands before committing this one.
4 years, 8 months ago (2016-04-05 22:53:36 UTC) #2
juncai
LGTM.
4 years, 8 months ago (2016-04-05 23:28:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857393002/1
4 years, 8 months ago (2016-04-08 19:00:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/16434) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 19:02:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857393002/20001
4 years, 8 months ago (2016-04-08 20:22:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/194077)
4 years, 8 months ago (2016-04-08 21:25:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857393002/20001
4 years, 8 months ago (2016-04-08 22:06:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 22:12:02 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 22:13:42 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c3ab3d07108f906137537c771de9b5bda0ef83c
Cr-Commit-Position: refs/heads/master@{#386221}

Powered by Google App Engine
This is Rietveld 408576698