Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: third_party/WebKit/Source/modules/webusb/USBDevice.h

Issue 1857393002: Remove page visibility requirement for WebUSB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@usb_indicator
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webusb/USBDevice.h
diff --git a/third_party/WebKit/Source/modules/webusb/USBDevice.h b/third_party/WebKit/Source/modules/webusb/USBDevice.h
index a5e01eecfc79aa19ed09b9093ba3e04a1c5a0434..9b5154b85c006e597c20bb8a9aadf5c400ccc3e0 100644
--- a/third_party/WebKit/Source/modules/webusb/USBDevice.h
+++ b/third_party/WebKit/Source/modules/webusb/USBDevice.h
@@ -9,7 +9,6 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/modules/v8/UnionTypesModules.h"
#include "core/dom/ContextLifecycleObserver.h"
-#include "core/page/PageLifecycleObserver.h"
#include "platform/heap/Handle.h"
#include "public/platform/modules/webusb/WebUSBDevice.h"
#include "public/platform/modules/webusb/WebUSBDeviceInfo.h"
@@ -26,8 +25,7 @@ class USBControlTransferParameters;
class USBDevice
: public GarbageCollectedFinalized<USBDevice>
, public ContextLifecycleObserver
- , public ScriptWrappable
- , public PageLifecycleObserver {
+ , public ScriptWrappable {
USING_GARBAGE_COLLECTED_MIXIN(USBDevice);
DEFINE_WRAPPERTYPEINFO();
public:
@@ -90,16 +88,12 @@ public:
// ContextLifecycleObserver interface.
void contextDestroyed() override;
- // PageLifecycleObserver interface.
- void pageVisibilityChanged() override;
-
DECLARE_TRACE();
private:
int findConfigurationIndex(uint8_t configurationValue) const;
int findInterfaceIndex(uint8_t interfaceNumber) const;
int findAlternateIndex(size_t interfaceIndex, uint8_t alternateSetting) const;
- bool ensurePageVisible(ScriptPromiseResolver*) const;
bool ensureNoDeviceOrInterfaceChangeInProgress(ScriptPromiseResolver*) const;
bool ensureDeviceConfigured(ScriptPromiseResolver*) const;
bool ensureInterfaceClaimed(uint8_t interfaceNumber, ScriptPromiseResolver*) const;

Powered by Google App Engine
This is Rietveld 408576698