Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1857343004: Mojo: Don't short-circuit when failing to deserialize arrays of native types. (Closed)

Created:
4 years, 8 months ago by Sam McNally
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Don't short-circuit when failing to deserialize arrays of native types. A comment claims that deserialization failures do not short-circuit deserialization of later elements. This updates the code to match the comment. Committed: https://crrev.com/7b9a981385ad9693d1c3cfd471fae890105b31ad Cr-Commit-Position: refs/heads/master@{#385649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/public/cpp/bindings/lib/array_serialization_traits.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
4 years, 8 months ago (2016-04-07 01:42:04 UTC) #2
Ken Rockot(use gerrit already)
Hah. Good catch. LGTM
4 years, 8 months ago (2016-04-07 01:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857343004/1
4 years, 8 months ago (2016-04-07 01:51:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 03:57:02 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 03:58:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b9a981385ad9693d1c3cfd471fae890105b31ad
Cr-Commit-Position: refs/heads/master@{#385649}

Powered by Google App Engine
This is Rietveld 408576698