Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: mojo/public/cpp/bindings/lib/array_serialization_traits.h

Issue 1857343004: Mojo: Don't short-circuit when failing to deserialize arrays of native types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/array_serialization_traits.h
diff --git a/mojo/public/cpp/bindings/lib/array_serialization_traits.h b/mojo/public/cpp/bindings/lib/array_serialization_traits.h
index 5e0e5afe8a0eaf73227f659c2ace84bfe5b80941..17817e01951b142f70e212e9099cf80d8ae9cad6 100644
--- a/mojo/public/cpp/bindings/lib/array_serialization_traits.h
+++ b/mojo/public/cpp/bindings/lib/array_serialization_traits.h
@@ -398,8 +398,8 @@ struct ArraySerializationStrategy<ArrayType, true> {
for (size_t i = 0; i < input->size(); ++i) {
// We don't short-circuit on failure since we can't know what the native
// type's ParamTraits' expectations are.
- success =
- success && DeserializeNative_(input->at(i), &result[i], context);
+ if (!DeserializeNative_(input->at(i), &result[i], context))
+ success = false;
}
output->Swap(&result);
return success;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698