Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857303002: Experiment: Add a flag to show search text in fake omnibox - device tablet (Closed)

Created:
4 years, 8 months ago by mcwilliams
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag to show search text in fake omnibox - device tablet BUG=600759 Committed: https://crrev.com/8762bc4ccca1255bb9034e4181dc44e4d678270c Cr-Commit-Position: refs/heads/master@{#385418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mcwilliams
4 years, 8 months ago (2016-04-05 17:20:43 UTC) #2
Bernhard Bauer
Code LGTM, but it looks like your description was squashed from multiple Git commits. You ...
4 years, 8 months ago (2016-04-05 22:08:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857303002/1
4 years, 8 months ago (2016-04-06 08:50:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 09:28:48 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:29:51 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8762bc4ccca1255bb9034e4181dc44e4d678270c
Cr-Commit-Position: refs/heads/master@{#385418}

Powered by Google App Engine
This is Rietveld 408576698