Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1857303002: Experiment: Add a flag to show search text in fake omnibox - device tablet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index a62a22028f677f7304356867559200f991e7dac3..67eb3863626fc98574f3a74be7482327562be0cf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -246,6 +246,11 @@ public class NewTabPage
&& !ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS);
}
+ @Override
+ public boolean isFakeOmniboxTextEnabledTablet() {
+ return ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_FAKE_OMNIBOX_TEXT);
+ }
+
private void recordOpenedMostVisitedItem(MostVisitedItem item) {
if (mIsDestroyed) return;
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_MOST_VISITED_ENTRY);
@@ -631,7 +636,8 @@ public class NewTabPage
}
private boolean isInSingleUrlBarMode(Context context) {
- if (DeviceFormFactor.isTablet(context)) return false;
+ if (DeviceFormFactor.isTablet(context)
+ && !mNewTabPageManager.isFakeOmniboxTextEnabledTablet()) return false;
return mSearchProviderHasLogo;
}

Powered by Google App Engine
This is Rietveld 408576698