Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1857263002: [d8] reset global handle on exit. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] reset global handle on exit. R=neis@chromium.org BUG=v8:4887 LOG=N Committed: https://crrev.com/7936f40562447bdb7c1a0914b07ff8f8c559e486 Cr-Commit-Position: refs/heads/master@{#35270}

Patch Set 1 #

Patch Set 2 : fix shared library build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/d8.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
4 years, 8 months ago (2016-04-05 15:50:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857263002/1
4 years, 8 months ago (2016-04-05 15:51:13 UTC) #3
neis
lgtm
4 years, 8 months ago (2016-04-05 15:54:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/12767)
4 years, 8 months ago (2016-04-05 15:55:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857263002/20001
4 years, 8 months ago (2016-04-05 16:01:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 16:22:16 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 16:23:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7936f40562447bdb7c1a0914b07ff8f8c559e486
Cr-Commit-Position: refs/heads/master@{#35270}

Powered by Google App Engine
This is Rietveld 408576698