src/d8.cc - Issue 1857263002: [d8] reset global handle on exit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 1857263002: [d8] reset global handle on exit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix shared library build Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index c23c1a4a9c722f0839fd4ca4976c41e90b10cda0..06883803f90091503fd133499ef3608f048ae8aa 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -2478,6 +2478,9 @@ int Shell::Main(int argc, char* argv[]) {

// Shut down contexts and collect garbage.

evaluation_context_.Reset();

+#ifndef V8_SHARED

+ stringify_function_.Reset();

+#endif // !V8_SHARED

CollectGarbage(isolate);

}

OnExit(isolate);

« no previous file with comments | « no previous file | no next file » | no next file with comments »