Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857203003: Settings People Revamp: Fix Mange Profile empty name crash. (Closed)

Created:
4 years, 8 months ago by tommycli
Modified:
4 years, 8 months ago
Reviewers:
dschuyler, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Fix Mange Profile empty name crash. Prevents sending an empty string name to C++. BUG=597868, 599842 Committed: https://crrev.com/f97a714079d2dc126c0d818f7593137ab3b62557 Cr-Commit-Position: refs/heads/master@{#385305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/manage_profile.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tommycli
dschuyler: PTAL thanks
4 years, 8 months ago (2016-04-05 21:22:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857203003/1
4 years, 8 months ago (2016-04-05 21:23:46 UTC) #4
Dan Beam
lgtm
4 years, 8 months ago (2016-04-05 21:33:38 UTC) #6
Dan Beam
(I looked at this briefly while you were out, and prototyped something similar)
4 years, 8 months ago (2016-04-05 21:34:11 UTC) #7
tommycli
On 2016/04/05 21:34:11, Dan Beam wrote: > (I looked at this briefly while you were ...
4 years, 8 months ago (2016-04-05 21:39:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857203003/1
4 years, 8 months ago (2016-04-05 21:39:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 22:25:18 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:27:01 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f97a714079d2dc126c0d818f7593137ab3b62557
Cr-Commit-Position: refs/heads/master@{#385305}

Powered by Google App Engine
This is Rietveld 408576698