chrome/browser/resources/settings/people_page/manage_profile.js - Issue 1857203003: Settings People Revamp: Fix Mange Profile empty name crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/manage_profile.js

Issue 1857203003: Settings People Revamp: Fix Mange Profile empty name crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/people_page/manage_profile.js

diff --git a/chrome/browser/resources/settings/people_page/manage_profile.js b/chrome/browser/resources/settings/people_page/manage_profile.js

index ff1f777b74ff323fbb692910aadd43b209fdce16..1a89511edcccf8be86a22b714a072753d00e1629 100644

--- a/chrome/browser/resources/settings/people_page/manage_profile.js

+++ b/chrome/browser/resources/settings/people_page/manage_profile.js

@@ -52,6 +52,9 @@ Polymer({

* @param {!Event} event

onProfileNameChanged_: function(event) {

+ if (event.target.invalid)

+ return;

settings.SyncPrivateApi.setProfileIconAndName(this.profileIconUrl,

event.target.value);

« no previous file with comments | « chrome/browser/resources/settings/people_page/manage_profile.html ('k') | no next file » | no next file with comments »