Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1856693002: Revert of Ensure RenderFrameHost & NavigationHandle are not destroyed during commit (Closed)

Created:
4 years, 8 months ago by clamy
Modified:
4 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure RenderFrameHost & NavigationHandle are not destroyed during commit (patchset #2 id:20001 of https://codereview.chromium.org/1759123002/ ) Reason for revert: Now that the underlying reason for issue 589365 has been found and fixed, this investigation code can be removed. Original issue's description: > Ensure RenderFrameHost & NavigationHandle are not destroyed during commit > > This CL adds a boolean to RenderFrameHost and NavigationHandle to check if they > are destroyed during a navigation commit, which would lead to a use-after-free > bug. > > BUG=589365 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/764db137cad662c0b40399de0486b39048aa02b0 > Cr-Commit-Position: refs/heads/master@{#381713} TBR=nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589365 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/0a511b0dbcabbf6bb4244c992e2a80ec4353f514 Cr-Commit-Position: refs/heads/master@{#384898}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -40 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
clamy
Created Revert of Ensure RenderFrameHost & NavigationHandle are not destroyed during commit
4 years, 8 months ago (2016-04-04 12:15:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856693002/1
4 years, 8 months ago (2016-04-04 12:15:57 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/13235) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-04 12:17:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856693002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856693002/140001
4 years, 8 months ago (2016-04-04 12:29:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 8 months ago (2016-04-04 13:51:49 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:53:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a511b0dbcabbf6bb4244c992e2a80ec4353f514
Cr-Commit-Position: refs/heads/master@{#384898}

Powered by Google App Engine
This is Rietveld 408576698