Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1856693002: Revert of Ensure RenderFrameHost & NavigationHandle are not destroyed during commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index c19ed16a8bec64b641637a41429ac409231d4734..252a2e03d3990a4fc2263647aa8439275a4fb039 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -211,10 +211,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool same_page,
RenderFrameHostImpl* render_frame_host);
- // TODO(clamy): Remove this once enough data has been gathered for
- // crbug.com/589365.
- void set_is_in_commit(bool is_in_commit) { is_in_commit_ = is_in_commit; }
-
private:
friend class NavigationHandleImplTest;
@@ -296,12 +292,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// corresponding ServiceWorkerNetworkProvider is created in the renderer.
scoped_ptr<ServiceWorkerNavigationHandle> service_worker_handle_;
- // True if the RenderFrameHost that owns the NavigationHandle is in the
- // process of committing a navigation. This is temporary to help pinpoint
- // the cause of crbug.com/589365.
- // TODO(clamy): Remove once enough data has been gathered.
- bool is_in_commit_;
-
DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
};
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698