chrome/browser/resources/file_manager/background/js/background.js - Issue 185653014: [AudioPlayer] Fix a bug on changing 'expanded' status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/background/js/background.js

Issue 185653014: [AudioPlayer] Fix a bug on changing 'expanded' status (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/file_manager/background/js/background.js

diff --git a/chrome/browser/resources/file_manager/background/js/background.js b/chrome/browser/resources/file_manager/background/js/background.js

index b17c5a78ace59ac733fb8daa57bdecdf3f7e0b3b..7a4aa331b860c79b47a6e9603e64852c020fabff 100644

--- a/chrome/browser/resources/file_manager/background/js/background.js

+++ b/chrome/browser/resources/file_manager/background/js/background.js

@@ -764,9 +764,9 @@ audioPlayerInitializationQueue.run(function(callback) {

var audioPlayerCreateOptions = Object.freeze({

type: 'panel',

hidden: true,

- minHeight: newAudioPlayerEnabled ? 116 : (35 + 58),

+ minHeight: newAudioPlayerEnabled ? (44 + 73) : (35 + 58),

hirono 2014/03/05 17:24:01 nit: Maybe inline style comments about what the nu

minWidth: newAudioPlayerEnabled ? 292 : 280,

- height: newAudioPlayerEnabled ? 116 : (35 + 58), // default collapsed

+ height: newAudioPlayerEnabled ? (44 + 73) : (35 + 58), // collapsed

width: newAudioPlayerEnabled ? 292 : 280,

});