[AudioPlayer] Fix a bug on changing 'expanded' status

chrome/browser/resources/file_manager/audio_player/js/audio_player.js

Index: chrome/browser/resources/file_manager/audio_player/js/audio_player.js
diff --git a/chrome/browser/resources/file_manager/audio_player/js/audio_player.js b/chrome/browser/resources/file_manager/audio_player/js/audio_player.js
index f380e32590bbb21f95f8e199bf583d396ef2f328..4de427369369c11c4f907407d6c16f7af4c316f1 100644
--- a/chrome/browser/resources/file_manager/audio_player/js/audio_player.js
+++ b/chrome/browser/resources/file_manager/audio_player/js/audio_player.js
@@ -103,6 +103,8 @@ AudioPlayer.prototype.load = function(playlist) {
   window.appState = JSON.parse(JSON.stringify(playlist));  // cloning
   util.saveAppState();
 
+  this.isExpanded_ = this.model_.expanded;
+
   // Resolving entries has to be done after the volume manager is initialized.
   this.volumeManager_.ensureInitialized(function() {
     util.URLsToEntries(playlist.items, function(entries) {
@@ -116,6 +118,10 @@ AudioPlayer.prototype.load = function(playlist) {
 
       this.trackListItems_.splice(0);
 
+      // Makes it sure that the track list is now empty to the handler, before
+      // adding new tracks.
+      Platform.performMicrotaskCheckpoint();

[hirono, 2014/03/05 17:24:01]

Just curious, what goes wrong without the line?
I'm guessing it is needed to ensure to assign -1 to currentTrackIndex, but not
sure.

[yoshiki, 2014/03/05 18:30:41]

Yes, that's correct.

[hirono, 2014/03/06 03:44:47]

So how about removing this.trackListItems_ member and reassigning the new track
items to this.player_.tracks here?
It shows the idea of replacing whole the track list more explicitly. We can
remove the hack. And it saves the number of update from ArrayObserver.

[yoshiki, 2014/03/06 08:25:07]

Done

+
       for (var i = 0; i != this.entries_.length; i++) {
         var entry = this.entries_[i];
         var onClick = this.select_.bind(this, i, false /* no restore */);
@@ -268,7 +274,7 @@ AudioPlayer.prototype.onResize_ = function(event) {
  * @type {number}
  * @const
  */
-AudioPlayer.HEADER_HEIGHT = 28;
+AudioPlayer.HEADER_HEIGHT = 33;  // 32px + border 1px
 
 /**
  * Track height in pixels.
@@ -282,7 +288,7 @@ AudioPlayer.TRACK_HEIGHT = 44;
  * @type {number}
  * @const
  */
-AudioPlayer.CONTROLS_HEIGHT = 72;
+AudioPlayer.CONTROLS_HEIGHT = 73;  // 72px + border 1px
 
 /**
  * Default number of items in the expanded mode.
@@ -315,6 +321,10 @@ AudioPlayer.prototype.onModelExpandedChanged = function(oldValue, newValue) {
   if (this.isExpanded_ !== newValue) {
     this.isExpanded_ = newValue;
     this.syncHeight_();
+
+    // Saves new state.
+    window.appState.expanded = newValue;
+    util.saveAppState();
   }
 };