Issue 185653011: RenderLayer::hasVisibleContent() incorrect when layer removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185653011: RenderLayer::hasVisibleContent() incorrect when layer removed (Closed)

Created:
6 years, 9 months ago by abarth-chromium

Modified:
6 years, 9 months ago

Reviewers:
ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

RenderLayer::hasVisibleContent() incorrect when layer removed Prior to this CL, we were incorrectlyd dirtying RenderLayer::hasVisibleContent() when removing a RenderLayer from the layer tree. This caused us to incorrectly believe that the parent layer lacked visible content. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168359

Patch Set 1 #

Patch Set 2 : Reupload #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -0 lines)			Patch
A	LayoutTests/compositing/visibility/visibility-remove-layer.html	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download
A	LayoutTests/compositing/visibility/visibility-remove-layer-expected.html	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/185653011/2

6 years, 9 months ago (2014-03-04 01:23:40 UTC) #3

abarth-chromium

6 years, 9 months ago (2014-03-04 04:45:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r168359 (presubmit successful).

Expand Messages | Collapse Messages