Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 185653011: RenderLayer::hasVisibleContent() incorrect when layer removed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reupload Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/compositing/visibility/visibility-remove-layer-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1400 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 1411
1412 if (oldChild->stackingNode()->isNormalFlowOnly()) 1412 if (oldChild->stackingNode()->isNormalFlowOnly())
1413 m_stackingNode->dirtyNormalFlowList(); 1413 m_stackingNode->dirtyNormalFlowList();
1414 if (!oldChild->stackingNode()->isNormalFlowOnly() || oldChild->firstChild()) { 1414 if (!oldChild->stackingNode()->isNormalFlowOnly() || oldChild->firstChild()) {
1415 // Dirty the z-order list in which we are contained. When called via th e 1415 // Dirty the z-order list in which we are contained. When called via th e
1416 // reattachment process in removeOnlyThisLayer, the layer may already be disconnected 1416 // reattachment process in removeOnlyThisLayer, the layer may already be disconnected
1417 // from the main layer tree, so we need to null-check the |stackingConta iner| value. 1417 // from the main layer tree, so we need to null-check the |stackingConta iner| value.
1418 oldChild->stackingNode()->dirtyStackingContainerZOrderLists(); 1418 oldChild->stackingNode()->dirtyStackingContainerZOrderLists();
1419 } 1419 }
1420 1420
1421 if (renderer()->style()->visibility() != VISIBLE)
1422 dirtyVisibleContentStatus();
1423
1421 oldChild->setPreviousSibling(0); 1424 oldChild->setPreviousSibling(0);
1422 oldChild->setNextSibling(0); 1425 oldChild->setNextSibling(0);
1423 oldChild->setParent(0); 1426 oldChild->setParent(0);
1424 1427
1425 oldChild->updateDescendantDependentFlags(); 1428 oldChild->updateDescendantDependentFlags();
1426 if (subtreeContainsOutOfFlowPositionedLayer(oldChild)) { 1429 if (subtreeContainsOutOfFlowPositionedLayer(oldChild)) {
1427 // It may now be the case that a layer no longer has an unclipped 1430 // It may now be the case that a layer no longer has an unclipped
1428 // descendant. Let the compositor know that it needs to reevaluate 1431 // descendant. Let the compositor know that it needs to reevaluate
1429 // its compositing requirements to check this. 1432 // its compositing requirements to check this.
1430 compositor()->setNeedsUpdateCompositingRequirementsState(); 1433 compositor()->setNeedsUpdateCompositingRequirementsState();
(...skipping 2600 matching lines...) Expand 10 before | Expand all | Expand 10 after
4031 } 4034 }
4032 } 4035 }
4033 4036
4034 void showLayerTree(const WebCore::RenderObject* renderer) 4037 void showLayerTree(const WebCore::RenderObject* renderer)
4035 { 4038 {
4036 if (!renderer) 4039 if (!renderer)
4037 return; 4040 return;
4038 showLayerTree(renderer->enclosingLayer()); 4041 showLayerTree(renderer->enclosingLayer());
4039 } 4042 }
4040 #endif 4043 #endif
OLDNEW
« no previous file with comments | « LayoutTests/compositing/visibility/visibility-remove-layer-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698