Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 185653006: Handle NULL RenderWidget in RenderViewImpl::createPopupMenu (Closed)

Created:
6 years, 9 months ago by adamk
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Handle NULL RenderWidget in RenderViewImpl::createPopupMenu The Blink side is being updated to properly handle this case in https://codereview.chromium.org/183833014/ BUG=347901 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254666

Patch Set 1 : Again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
adamk
Not sure how to write a test for this...
6 years, 9 months ago (2014-03-03 19:27:37 UTC) #1
jamesr
Good question about tests, I've no idea either. lgtm
6 years, 9 months ago (2014-03-03 20:17:27 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 9 months ago (2014-03-03 20:29:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/185653006/20001
6 years, 9 months ago (2014-03-03 20:30:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 22:55:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=273369
6 years, 9 months ago (2014-03-03 22:55:12 UTC) #6
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 9 months ago (2014-03-03 22:58:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/185653006/20001
6 years, 9 months ago (2014-03-03 23:02:55 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 05:18:30 UTC) #9
Message was sent while issue was closed.
Change committed as 254666

Powered by Google App Engine
This is Rietveld 408576698