content/renderer/render_view_impl.cc - Issue 185653006: Handle NULL RenderWidget in RenderViewImpl::createPopupMenu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 185653006: Handle NULL RenderWidget in RenderViewImpl::createPopupMenu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Again Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 89426e084a9a858c69d9d52c8e2c65893a1ed337..bf4357f926a73e19a462773b0bd7077aed2f0845 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1853,6 +1853,8 @@ WebView* RenderViewImpl::createView(

WebWidget* RenderViewImpl::createPopupMenu(blink::WebPopupType popup_type) {

RenderWidget* widget =

RenderWidget::Create(routing_id_, popup_type, screen_info_);

+ if (!widget)

+ return NULL;

if (screen_metrics_emulator_) {

widget->SetPopupOriginAdjustmentsForEmulation(

screen_metrics_emulator_.get());

« no previous file with comments | « no previous file | no next file » | no next file with comments »