tools/buildbot_spec.py - Issue 1856403002: Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/buildbot_spec.py

Issue 1856403002: Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/buildbot_spec.py

diff --git a/tools/buildbot_spec.py b/tools/buildbot_spec.py

index 8e2f7b7b1370cd260726721274e98674f5692bc2..551907038eec0856ce470c9d3850b9dcf4a1b5d0 100755

--- a/tools/buildbot_spec.py

+++ b/tools/buildbot_spec.py

@@ -301,7 +301,7 @@ def get_builder_spec(builder_name):

rv['do_perf_steps'] = (role == builder_name_schema.BUILDER_ROLE_PERF or

(role == builder_name_schema.BUILDER_ROLE_TEST and

configuration == CONFIG_DEBUG))

- if 'Valgrind' in builder_name:

+ if rv['do_test_steps'] and 'Valgrind' in builder_name:

rv['do_perf_steps'] = True

if 'GalaxyS4' in builder_name:

rv['do_perf_steps'] = False

« no previous file with comments | « no previous file | no next file » | no next file with comments »