Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: tools/buildbot_spec.py

Issue 1856403002: Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright 2015 Google Inc. 2 # Copyright 2015 Google Inc.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 7
8 #!/usr/bin/env python 8 #!/usr/bin/env python
9 9
10 usage = ''' 10 usage = '''
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 configuration = builder_dict.get( 294 configuration = builder_dict.get(
295 'configuration', CONFIG_DEBUG) 295 'configuration', CONFIG_DEBUG)
296 arch = (builder_dict.get('arch') or builder_dict.get('target_arch')) 296 arch = (builder_dict.get('arch') or builder_dict.get('target_arch'))
297 if ('Win' in builder_dict.get('os', '') and arch == 'x86_64'): 297 if ('Win' in builder_dict.get('os', '') and arch == 'x86_64'):
298 configuration += '_x64' 298 configuration += '_x64'
299 rv['configuration'] = configuration 299 rv['configuration'] = configuration
300 rv['do_test_steps'] = role == builder_name_schema.BUILDER_ROLE_TEST 300 rv['do_test_steps'] = role == builder_name_schema.BUILDER_ROLE_TEST
301 rv['do_perf_steps'] = (role == builder_name_schema.BUILDER_ROLE_PERF or 301 rv['do_perf_steps'] = (role == builder_name_schema.BUILDER_ROLE_PERF or
302 (role == builder_name_schema.BUILDER_ROLE_TEST and 302 (role == builder_name_schema.BUILDER_ROLE_TEST and
303 configuration == CONFIG_DEBUG)) 303 configuration == CONFIG_DEBUG))
304 if 'Valgrind' in builder_name: 304 if rv['do_test_steps'] and 'Valgrind' in builder_name:
305 rv['do_perf_steps'] = True 305 rv['do_perf_steps'] = True
306 if 'GalaxyS4' in builder_name: 306 if 'GalaxyS4' in builder_name:
307 rv['do_perf_steps'] = False 307 rv['do_perf_steps'] = False
308 308
309 rv['build_targets'] = build_targets_from_builder_dict( 309 rv['build_targets'] = build_targets_from_builder_dict(
310 builder_dict, rv['do_test_steps'], rv['do_perf_steps']) 310 builder_dict, rv['do_test_steps'], rv['do_perf_steps'])
311 311
312 # Do we upload perf results? 312 # Do we upload perf results?
313 upload_perf_results = False 313 upload_perf_results = False
314 if role == builder_name_schema.BUILDER_ROLE_PERF: 314 if role == builder_name_schema.BUILDER_ROLE_PERF:
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 if len(sys.argv) == 2 and sys.argv[1] == 'test': 394 if len(sys.argv) == 2 and sys.argv[1] == 'test':
395 self_test() 395 self_test()
396 sys.exit(0) 396 sys.exit(0)
397 397
398 if len(sys.argv) != 3: 398 if len(sys.argv) != 3:
399 print usage 399 print usage
400 sys.exit(1) 400 sys.exit(1)
401 401
402 with open(sys.argv[1], 'w') as out: 402 with open(sys.argv[1], 'w') as out:
403 json.dump(get_builder_spec(sys.argv[2]), out) 403 json.dump(get_builder_spec(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698