Subzero. Fixes Browser Build

Subzero. Fixes Browser build.

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=681f90fe6f4930c11d87a63d1c47cbb95a57f61b

[John, 2016-04-05 13:09:34]

jpp@chromium.org changed reviewers:
+ eholk@chromium.org, kschimpf@google.com, sehr@chromium.org,
stichnot@chromium.org

[John, 2016-04-05 13:09:53]

Description was changed from

==========
Subzero. Fixes Makefile.

BUG=
==========

to

==========
Subzero. Fixes Browser build.

BUG=
==========

[Jim Stichnoth, 2016-04-05 13:10:41]

lgtm

https://codereview.chromium.org/1856323004/diff/20001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1856323004/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:95: #if !ALLOW_WASM
I'm surprised this is necessary, because of BuildDefs::wasm()

[John, 2016-04-05 13:14:09]

presubmitting and landing.

https://codereview.chromium.org/1856323004/diff/20001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1856323004/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:95: #if !ALLOW_WASM
On 2016/04/05 13:10:41, stichnot wrote:
> I'm surprised this is necessary, because of BuildDefs::wasm()

the if(constexpr) guard is "weaker" than an #if. The compiler will still parse,
and verify whatever lives within the if-guarded region, even if you have if(0).
I.e.,

if (0) {
  this is invalid C++
}

will not compile (the same goes to if(Zero), where constexpr bool Zero = 0)

[Jim Stichnoth, 2016-04-05 13:18:38]

https://codereview.chromium.org/1856323004/diff/20001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1856323004/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:95: #if !ALLOW_WASM
On 2016/04/05 13:14:08, John wrote:
> On 2016/04/05 13:10:41, stichnot wrote:
> > I'm surprised this is necessary, because of BuildDefs::wasm()
> 
> the if(constexpr) guard is "weaker" than an #if. The compiler will still
parse,
> and verify whatever lives within the if-guarded region, even if you have
if(0).
> I.e.,
> 
> if (0) {
>   this is invalid C++
> }
> 
> will not compile (the same goes to if(Zero), where constexpr bool Zero = 0)

Oh, right, I forgot about the fact that this code is no longer compilable
because of the #if in the include file.

[John, 2016-04-05 13:20:53]

Description was changed from

==========
Subzero. Fixes Browser build.

BUG=
==========

to

==========
Subzero. Fixes Browser build.

BUG=
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-04-05 13:20:54]

Committed patchset #2 (id:20001) manually as
681f90fe6f4930c11d87a63d1c47cbb95a57f61b (presubmit successful).