Subzero. Fixes Browser Build

src/IceCompiler.cpp

 //===- subzero/src/IceCompiler.cpp - Driver for bitcode translation -------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 74 matching lines @@
                            !wasmInput(IRFilename);
   const bool WasmBuildOnRead = Flags.getBuildOnRead() && wasmInput(IRFilename);
   if (BuildOnRead) {
     std::unique_ptr<PNaClTranslator> PTranslator(new PNaClTranslator(&Ctx));
     std::unique_ptr<llvm::StreamingMemoryObject> MemObj(
         new llvm::StreamingMemoryObjectImpl(InputStream.release()));
     PTranslator->translate(IRFilename, std::move(MemObj));
     Translator.reset(PTranslator.release());
   } else if (WasmBuildOnRead) {
     if (BuildDefs::wasm()) {
+#if !ALLOW_WASM

[Jim Stichnoth, 2016/04/05 13:10:41]

I'm surprised this is necessary, because of BuildDefs::wasm()

[John, 2016/04/05 13:14:08]

the if(constexpr) guard is "weaker" than an #if. The compiler will still parse,
and verify whatever lives within the if-guarded region, even if you have if(0).
I.e.,

if (0) {
  this is invalid C++
}

will not compile (the same goes to if(Zero), where constexpr bool Zero = 0)

[Jim Stichnoth, 2016/04/05 13:18:38]

Oh, right, I forgot about the fact that this code is no longer compilable
because of the #if in the include file.

+      assert(false && "wasm not allowed");
+#else
       std::unique_ptr<WasmTranslator> WTranslator(new WasmTranslator(&Ctx));
 
       WTranslator->translate(IRFilename, std::move(InputStream));
 
       Translator.reset(WTranslator.release());
+#endif // !ALLOW_WASM
     } else {
       Ctx.getStrError() << "WASM support not enabled\n";
       Ctx.getErrorStatus()->assign(EC_Args);
       return;
     }
   } else if (BuildDefs::llvmIr()) {
     if (BuildDefs::browser()) {
       Ctx.getStrError()
           << "non BuildOnRead is not supported w/ PNACL_BROWSER_TRANSLATOR\n";
       Ctx.getErrorStatus()->assign(EC_Args);
@@ skipping 51 matching lines @@
     Ctx.dumpTimers();
 
   if (getFlags().getTimeEachFunction()) {
     constexpr bool NoDumpCumulative = false;
     Ctx.dumpTimers(GlobalContext::TSK_Funcs, NoDumpCumulative);
   }
   Ctx.dumpStats();
 }
 
 } // end of namespace Ice