Chromium Code Reviews
Help | Chromium Project | Sign in
(258)

Issue 18563002: Move SendAutofillTypePredictions() into AutofillDriver. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by blundell
Modified:
1 year, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, sgurun, benm (inactive)
Visibility:
Public.

Description

Move SendAutofillTypePredictions() into AutofillDriver. This CL abstracts the implementation of sending autofill type predictions to the renderer out of autofill core code and into the driver implementations. BUG=247015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209807

Patch Set 1 #

Total comments: 10

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -25 lines) Patch
M components/autofill/content/browser/autofill_driver_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/browser/autofill_driver_impl.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M components/autofill/content/browser/autofill_driver_impl_unittest.cc View 1 4 chunks +51 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_driver.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 4 chunks +3 lines, -20 lines 0 comments Download
M components/autofill/core/browser/test_autofill_driver.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/test_autofill_driver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/common/form_data_predictions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/common/form_data_predictions.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M components/autofill/core/common/form_field_data_predictions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/common/form_field_data_predictions.cc View 1 chunk +14 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
blundell
1 year, 9 months ago (2013-07-02 17:59:40 UTC) #1
Ilya Sherman
LGTM % nits, thanks. https://codereview.chromium.org/18563002/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc File components/autofill/content/browser/autofill_driver_impl_unittest.cc (right): https://codereview.chromium.org/18563002/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc#newcode168 components/autofill/content/browser/autofill_driver_impl_unittest.cc:168: FormStructure* form_structure = new FormStructure(form, ...
1 year, 9 months ago (2013-07-02 18:43:00 UTC) #2
blundell
Thanks! https://codereview.chromium.org/18563002/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc File components/autofill/content/browser/autofill_driver_impl_unittest.cc (right): https://codereview.chromium.org/18563002/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc#newcode168 components/autofill/content/browser/autofill_driver_impl_unittest.cc:168: FormStructure* form_structure = new FormStructure(form, std::string()); Oops, I ...
1 year, 9 months ago (2013-07-02 20:15:33 UTC) #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/18563002/7001
1 year, 9 months ago (2013-07-02 20:15:41 UTC) #4
I haz the power (commit-bot)
1 year, 9 months ago (2013-07-02 23:04:08 UTC) #5
Message was sent while issue was closed.
Change committed as 209807
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 700cc9d