Move SendAutofillTypePredictions() into AutofillDriver.

Move SendAutofillTypePredictions() into AutofillDriver.

This CL abstracts the implementation of sending autofill type predictions to
the renderer out of autofill core code and into the driver implementations.

BUG=247015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209807

[Ilya Sherman, 2013-07-02 18:43:00]

LGTM % nits, thanks.

https://codereview.chromium.org/18563002/diff/1/components/autofill/content/b...
File components/autofill/content/browser/autofill_driver_impl_unittest.cc
(right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/content/b...
components/autofill/content/browser/autofill_driver_impl_unittest.cc:168:
FormStructure* form_structure = new FormStructure(form, std::string());
nit: If you need to heap-allocate this, please protect this allocation with a
scoped_ptr, and subsequently pass ownership of the memory as appropriate.  In
fact, though, it looks like you could just stack-allocate this object.

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/autofill_driver.h (right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_driver.h:37: // Sends the field type
predictions specified in |forms|to the renderer. This
nit: "|forms|to" -> "|forms| to"

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_driver.h:41: const
std::vector<FormStructure*>& forms) = 0;
nit: #include <vector>?

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
File components/autofill/core/common/form_data_predictions.h (right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
components/autofill/core/common/form_data_predictions.h:32: bool
operator!=(const FormDataPredictions& predictions) const;
nit: Please add a comment that you're adding these for the sake of testing.

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
File components/autofill/core/common/form_field_data_predictions.h (right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
components/autofill/core/common/form_field_data_predictions.h:28: bool
operator!=(const FormFieldDataPredictions& predictions) const;
nit: Please add a comment that you're adding these for the sake of testing.

[blundell, 2013-07-02 20:15:33]

Thanks!

https://codereview.chromium.org/18563002/diff/1/components/autofill/content/b...
File components/autofill/content/browser/autofill_driver_impl_unittest.cc
(right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/content/b...
components/autofill/content/browser/autofill_driver_impl_unittest.cc:168:
FormStructure* form_structure = new FormStructure(form, std::string());
Oops, I was totally going to clean this up before sending out the CL ;). Thanks,
done.

On 2013/07/02 18:43:01, Ilya Sherman wrote:
> nit: If you need to heap-allocate this, please protect this allocation with a
> scoped_ptr, and subsequently pass ownership of the memory as appropriate.  In
> fact, though, it looks like you could just stack-allocate this object.

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/autofill_driver.h (right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_driver.h:37: // Sends the field type
predictions specified in |forms|to the renderer. This
On 2013/07/02 18:43:01, Ilya Sherman wrote:
> nit: "|forms|to" -> "|forms| to"

Done.

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_driver.h:41: const
std::vector<FormStructure*>& forms) = 0;
On 2013/07/02 18:43:01, Ilya Sherman wrote:
> nit: #include <vector>?

Done.

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
File components/autofill/core/common/form_data_predictions.h (right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
components/autofill/core/common/form_data_predictions.h:32: bool
operator!=(const FormDataPredictions& predictions) const;
On 2013/07/02 18:43:01, Ilya Sherman wrote:
> nit: Please add a comment that you're adding these for the sake of testing.

Done.

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
File components/autofill/core/common/form_field_data_predictions.h (right):

https://codereview.chromium.org/18563002/diff/1/components/autofill/core/comm...
components/autofill/core/common/form_field_data_predictions.h:28: bool
operator!=(const FormFieldDataPredictions& predictions) const;
On 2013/07/02 18:43:01, Ilya Sherman wrote:
> nit: Please add a comment that you're adding these for the sake of testing.

Done.

[commit-bot: I haz the power, 2013-07-02 20:15:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/18563002/7001

[commit-bot: I haz the power, 2013-07-02 23:04:08]

Change committed as 209807