Issue 185593010: Web Animations: Sort Players in DocumentTimeline::serviceAnimations

Issue 185593010: Web Animations: Sort Players in DocumentTimeline::serviceAnimations (Closed)

Created:
6 years, 9 months ago by Timothy Loh

Modified:
6 years, 9 months ago

Reviewers:
alancutter1, dstockwell, alancutter (OOO until 2018), Eric Willigers

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Web Animations: Sort Players in DocumentTimeline::serviceAnimations This patch makes Animations get serviced in the order specified by the spec[1]. This means that once custom effect are implemented, they will be queued up in the correct order. This also gets us closer to having the animation stack in a correct order (I'm thinking of emptying the stack after getting out the compositable values, as we traverse the animations in the correct order). [1] http://dev.w3.org/fxtf/web-animations/#the-animation-stack BUG=334936 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168597

Patch Set 1 : tweak tests once more :| #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : :| #

Total comments: 1

Patch Set 4 : add some braces #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -8 lines)			Patch
M	Source/core/animation/DocumentTimeline.cpp	View		1 chunk	+12 lines, -8 lines	0 comments	Download
M	Source/core/animation/Player.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/animation/Player.cpp	View		3 chunks	+22 lines, -0 lines	0 comments	Download
M	Source/core/animation/PlayerTest.cpp	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Eric Willigers

lgtm https://codereview.chromium.org/185593010/diff/80001/Source/core/animation/PlayerTest.cpp File Source/core/animation/PlayerTest.cpp (right): https://codereview.chromium.org/185593010/diff/80001/Source/core/animation/PlayerTest.cpp#newcode702 Source/core/animation/PlayerTest.cpp:702: for (int i = 0; i < 6; ...

6 years, 9 months ago (2014-03-05 06:00:10 UTC) #2

Timothy Loh

https://codereview.chromium.org/185593010/diff/80001/Source/core/animation/PlayerTest.cpp File Source/core/animation/PlayerTest.cpp (right): https://codereview.chromium.org/185593010/diff/80001/Source/core/animation/PlayerTest.cpp#newcode702 Source/core/animation/PlayerTest.cpp:702: for (int i = 0; i < 6; i++) ...

6 years, 9 months ago (2014-03-05 06:04:08 UTC) #3

dstockwell

lgtm https://codereview.chromium.org/185593010/diff/100001/Source/core/animation/PlayerTest.cpp File Source/core/animation/PlayerTest.cpp (right): https://codereview.chromium.org/185593010/diff/100001/Source/core/animation/PlayerTest.cpp#newcode702 Source/core/animation/PlayerTest.cpp:702: for (size_t i = 0; i < players.size(); ...

6 years, 9 months ago (2014-03-06 00:23:11 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/185593010/120001

6 years, 9 months ago (2014-03-06 00:31:35 UTC) #7

Message was sent while issue was closed.

Change committed as 168597

Expand Messages | Collapse Messages