Chromium Code Reviews Chromium Code Reviews
Issue 1855823003:
Implement Node.isConnected (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html |
| diff --git a/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html b/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..cb6972e9090cedb9b6579fb8deec2ce352182840 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html |
| @@ -0,0 +1,38 @@ |
| +<!DOCTYPE html> |
| +<script src='../resources/testharness.js'></script> |
| +<script src='../resources/testharnessreport.js'></script> |
| +<script src='../fast/dom/shadow/resources/shadow-dom.js'></script> |
| +<script src='resources/shadow-dom.js'></script> |
|
kochi
2016/04/04 09:22:42
Can you remove line 4-5?
I don't see any function
yuzuchan
2016/04/05 04:25:23
Done.
|
| +<div id="log"></div> |
| +<div id="host"></div> |
| +<script> |
| + |
| +var host = document.getElementById('host'); |
| +host.attachShadow({mode: 'open'}); |
| +var orphan1 = document.createElement('div'); |
| + |
| +test(function() { |
| + assert_false(orphan1.isConnected); |
| +}, 'isConnected of detached node should be false.'); |
| + |
| +test(function() { |
| + host.shadowRoot.appendChild(orphan1); |
| + assert_true(orphan1.isConnected); |
| +}, 'When inserted into a connected shadow tree, isConnected should be true.'); |
| + |
| + |
|
kochi
2016/04/04 09:22:42
nit: unnecessary newline?
I think it's okay to me
yuzuchan
2016/04/05 04:25:23
Done.
|
| +test(function() { |
| + var orphan2 = document.createElement('div'); |
| + host.appendChild(orphan2); |
| + assert_true(orphan2.isConnected); |
| +}, 'When inserted into a document tree, isConnected should be true.'); |
| + |
| +test(function() { |
| + var orphan3 = document.createElement('div'); |
| + var host2 = document.createElement('div'); |
| + host2.attachShadow({mode: 'open'}); |
| + host2.shadowRoot.appendChild(orphan3); |
| + assert_false(orphan3.isConnected); |
|
kochi
2016/04/04 09:22:42
It's better to check all the ancestors (host2.shad
yuzuchan
2016/04/05 04:25:23
Done.
|
| +}, 'When inserted into a detached tree, isConnected should be false.'); |
| + |
|
kochi
2016/04/04 09:22:42
Could you also add a test case where shadow host i
yuzuchan
2016/04/05 04:25:23
Done.
|
| +</script> |
