third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html - Issue 1855823003: Implement Node.isConnected

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html

Issue 1855823003: Implement Node.isConnected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use inDocument Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../resources/testharness.js'></script>

	3 <script src='../resources/testharnessreport.js'></script>

	4 <script src='../fast/dom/shadow/resources/shadow-dom.js'></script>

	5 <script src='resources/shadow-dom.js'></script>
	kochi 2016/04/04 09:22:42 Can you remove line 4-5? I don't see any function Can you remove line 4-5? I don't see any function in these js lib is used in this test. yuzuchan 2016/04/05 04:25:23 Done. Show quoted text On 2016/04/04 at 09:22:42, kochi wrote: > Can you remove line 4-5? > I don't see any function in these js lib is used in this test. Done.
	6 <div id="log"></div>

	7 <div id="host"></div>

	8 <script>

	9

	10 var host = document.getElementById('host');

	11 host.attachShadow({mode: 'open'});

	12 var orphan1 = document.createElement('div');

	13

	14 test(function() {

	15 assert_false(orphan1.isConnected);

	16 }, 'isConnected of detached node should be false.');

	17

	18 test(function() {

	19 host.shadowRoot.appendChild(orphan1);

	20 assert_true(orphan1.isConnected);

	21 }, 'When inserted into a connected shadow tree, isConnected should be true.');

	22

	23
	kochi 2016/04/04 09:22:42 nit: unnecessary newline? I think it's okay to me nit: unnecessary newline? I think it's okay to merge above 2 tests into one test(). yuzuchan 2016/04/05 04:25:23 Done. Show quoted text On 2016/04/04 at 09:22:42, kochi wrote: > nit: unnecessary newline? > > I think it's okay to merge above 2 tests into one test(). Done.
	24 test(function() {

	25 var orphan2 = document.createElement('div');

	26 host.appendChild(orphan2);

	27 assert_true(orphan2.isConnected);

	28 }, 'When inserted into a document tree, isConnected should be true.');

	29

	30 test(function() {

	31 var orphan3 = document.createElement('div');

	32 var host2 = document.createElement('div');

	33 host2.attachShadow({mode: 'open'});

	34 host2.shadowRoot.appendChild(orphan3);

	35 assert_false(orphan3.isConnected);
	kochi 2016/04/04 09:22:42 It's better to check all the ancestors (host2.shad It's better to check all the ancestors (host2.shadowRoot, host2) is not connected here. yuzuchan 2016/04/05 04:25:23 Done. Show quoted text On 2016/04/04 at 09:22:42, kochi wrote: > It's better to check all the ancestors (host2.shadowRoot, host2) is not connected here. Done.
	36 }, 'When inserted into a detached tree, isConnected should be false.');

	37
	kochi 2016/04/04 09:22:42 Could you also add a test case where shadow host i Could you also add a test case where shadow host is appended in a shadow tree (and then parenting shadow host is detached from the document)? yuzuchan 2016/04/05 04:25:23 Done. Show quoted text On 2016/04/04 at 09:22:42, kochi wrote: > Could you also add a test case where shadow host is appended in a shadow tree > (and then parenting shadow host is detached from the document)? Done.
	38 </script>

OLD	NEW