Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1855643002: More strong mode changes to analysis_server (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Backout changes to options file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -149 lines) Patch
M pkg/analysis_server/benchmark/integration/input_converter.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/log_file_input_converter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_manager.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/collections.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 18 chunks +77 lines, -65 lines 0 comments Download
M pkg/analysis_server/test/channel/web_socket_channel_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 15 chunks +16 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/linter/linter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/codegen/tools.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 3 chunks +11 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-02 00:35:33 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-02 00:54:31 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-02 01:00:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f9b575e5b3d5e68879475935095bde4964020dce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698