pkg/analysis_server/lib/src/services/refactoring/inline_method.dart - Issue 1855643002: More strong mode changes to analysis_server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

Issue 1855643002: More strong mode changes to analysis_server (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Backout changes to options file Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/inline_local.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

index c136c219743db3b66db9072b8111c179513b84da..ca243c4b0673c97f2f1fa17f6b40c267787927ff 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

@@ -280,12 +280,12 @@ class InlineMethodRefactoringImpl extends RefactoringImpl

// prepare method information

result.addStatus(_prepareMethod());

if (result.hasFatalError) {

- return new Future.value(result);

+ return new Future<RefactoringStatus>.value(result);

}

// maybe operator

if (_methodElement.isOperator) {

result = new RefactoringStatus.fatal('Cannot inline operator.');

- return new Future.value(result);

+ return new Future<RefactoringStatus>.value(result);

}

// analyze method body

result.addStatus(_prepareMethodParts());