Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1855633002: Revert of [chromecast] Pass media task runner to MediaPipelineBackendManager. (Closed)

Created:
4 years, 8 months ago by tianyuwang1
Modified:
4 years, 8 months ago
Reviewers:
lcwu1, halliwell, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [chromecast] Pass media task runner to MediaPipelineBackendManager. (patchset #8 id:140001 of https://codereview.chromium.org/1845783002/ ) Reason for revert: Broke chromecast. Will reland it after that's fixed. Original issue's description: > [chromecast] Pass media task runner to MediaPipelineBackendManager. > > This required making MediaPipelineBackendManager non-singleton and > passed around wherever required. > > BUG=597450 > > Committed: https://crrev.com/7f6a0145ae3deb8920771b2a2347af5f5c91aedd > Cr-Commit-Position: refs/heads/master@{#384643} TBR=alokp@chromium.org,halliwell@chromium.org,kmackay@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597450 Committed: https://crrev.com/256cb1b61f5f9658536b083ff2862152348cf0a3 Cr-Commit-Position: refs/heads/master@{#384756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -109 lines) Patch
M chromecast/browser/cast_browser_main_parts.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 3 chunks +1 line, -12 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager.h View 2 chunks +1 line, -6 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager_factory.h View 2 chunks +1 line, -6 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager_factory.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/backend/media_pipeline_backend_manager.h View 2 chunks +12 lines, -12 lines 0 comments Download
M chromecast/media/cma/backend/media_pipeline_backend_manager.cc View 2 chunks +48 lines, -30 lines 0 comments Download
M chromecast/media/cma/backend/media_pipeline_backend_wrapper.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chromecast/media/cma/backend/media_pipeline_backend_wrapper.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
tianyuwang1
Created Revert of [chromecast] Pass media task runner to MediaPipelineBackendManager.
4 years, 8 months ago (2016-04-02 00:29:31 UTC) #1
tianyuwang1
4 years, 8 months ago (2016-04-02 00:29:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855633002/1
4 years, 8 months ago (2016-04-02 00:30:05 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-02 00:30:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855633002/1
4 years, 8 months ago (2016-04-02 00:32:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-02 00:32:31 UTC) #10
lcwu1
rs lgtm
4 years, 8 months ago (2016-04-02 00:33:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855633002/1
4 years, 8 months ago (2016-04-02 00:34:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 00:35:13 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/256cb1b61f5f9658536b083ff2862152348cf0a3 Cr-Commit-Position: refs/heads/master@{#384756}
4 years, 8 months ago (2016-04-02 00:36:25 UTC) #17
tianyuwang1
4 years, 8 months ago (2016-04-02 00:41:22 UTC) #19
alokp
4 years, 8 months ago (2016-04-02 04:17:40 UTC) #20
Message was sent while issue was closed.
For future reference, you can always commit a revert by adding "TBR=<owner>" in
patch description.

Powered by Google App Engine
This is Rietveld 408576698