Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chromecast/media/audio/cast_audio_manager.cc

Issue 1855633002: Revert of [chromecast] Pass media task runner to MediaPipelineBackendManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/media/audio/cast_audio_manager.h" 5 #include "chromecast/media/audio/cast_audio_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "chromecast/media/audio/cast_audio_output_stream.h" 10 #include "chromecast/media/audio/cast_audio_output_stream.h"
11 #include "chromecast/media/base/media_message_loop.h"
11 #include "chromecast/media/cma/backend/media_pipeline_backend_manager.h" 12 #include "chromecast/media/cma/backend/media_pipeline_backend_manager.h"
13 #include "chromecast/public/cast_media_shlib.h"
14 #include "chromecast/public/media/media_pipeline_backend.h"
12 15
13 namespace { 16 namespace {
14 // TODO(alokp): Query the preferred value from media backend. 17 // TODO(alokp): Query the preferred value from media backend.
15 const int kDefaultSampleRate = 48000; 18 const int kDefaultSampleRate = 48000;
16 19
17 // Define bounds for the output buffer size (in frames). 20 // Define bounds for the output buffer size (in frames).
18 // Note: These values are copied from AudioManagerPulse implementation. 21 // Note: These values are copied from AudioManagerPulse implementation.
19 // TODO(alokp): Query the preferred value from media backend. 22 // TODO(alokp): Query the preferred value from media backend.
20 static const int kMinimumOutputBufferSize = 512; 23 static const int kMinimumOutputBufferSize = 512;
21 static const int kMaximumOutputBufferSize = 8192; 24 static const int kMaximumOutputBufferSize = 8192;
22 static const int kDefaultOutputBufferSize = 2048; 25 static const int kDefaultOutputBufferSize = 2048;
23 } // namespace 26 } // namespace
24 27
25 namespace chromecast { 28 namespace chromecast {
26 namespace media { 29 namespace media {
27 30
28 CastAudioManager::CastAudioManager(::media::AudioLogFactory* audio_log_factory, 31 CastAudioManager::CastAudioManager(::media::AudioLogFactory* audio_log_factory)
29 MediaPipelineBackendManager* backend_manager) 32 : AudioManagerBase(audio_log_factory) {}
30 : AudioManagerBase(audio_log_factory), backend_manager_(backend_manager) {
31 }
32 33
33 CastAudioManager::~CastAudioManager() { 34 CastAudioManager::~CastAudioManager() {
34 Shutdown(); 35 Shutdown();
35 } 36 }
36 37
37 bool CastAudioManager::HasAudioOutputDevices() { 38 bool CastAudioManager::HasAudioOutputDevices() {
38 return true; 39 return true;
39 } 40 }
40 41
41 bool CastAudioManager::HasAudioInputDevices() { 42 bool CastAudioManager::HasAudioInputDevices() {
(...skipping 14 matching lines...) Expand all
56 const std::string& device_id) { 57 const std::string& device_id) {
57 LOG(WARNING) << "No support for input audio devices"; 58 LOG(WARNING) << "No support for input audio devices";
58 // Need to send a valid AudioParameters object even when it will unused. 59 // Need to send a valid AudioParameters object even when it will unused.
59 return ::media::AudioParameters( 60 return ::media::AudioParameters(
60 ::media::AudioParameters::AUDIO_PCM_LOW_LATENCY, 61 ::media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
61 ::media::CHANNEL_LAYOUT_STEREO, 48000, 16, 1024); 62 ::media::CHANNEL_LAYOUT_STEREO, 48000, 16, 1024);
62 } 63 }
63 64
64 scoped_ptr<MediaPipelineBackend> CastAudioManager::CreateMediaPipelineBackend( 65 scoped_ptr<MediaPipelineBackend> CastAudioManager::CreateMediaPipelineBackend(
65 const MediaPipelineDeviceParams& params) { 66 const MediaPipelineDeviceParams& params) {
66 return backend_manager_->CreateMediaPipelineBackend(params); 67 DCHECK(media::MediaMessageLoop::GetTaskRunner()->BelongsToCurrentThread());
68
69 return scoped_ptr<MediaPipelineBackend>(
70 MediaPipelineBackendManager::CreateMediaPipelineBackend(params));
67 } 71 }
68 72
69 ::media::AudioOutputStream* CastAudioManager::MakeLinearOutputStream( 73 ::media::AudioOutputStream* CastAudioManager::MakeLinearOutputStream(
70 const ::media::AudioParameters& params) { 74 const ::media::AudioParameters& params) {
71 DCHECK_EQ(::media::AudioParameters::AUDIO_PCM_LINEAR, params.format()); 75 DCHECK_EQ(::media::AudioParameters::AUDIO_PCM_LINEAR, params.format());
72 return new CastAudioOutputStream(params, this); 76 return new CastAudioOutputStream(params, this);
73 } 77 }
74 78
75 ::media::AudioOutputStream* CastAudioManager::MakeLowLatencyOutputStream( 79 ::media::AudioOutputStream* CastAudioManager::MakeLowLatencyOutputStream(
76 const ::media::AudioParameters& params, 80 const ::media::AudioParameters& params,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 } 116 }
113 117
114 ::media::AudioParameters output_params( 118 ::media::AudioParameters output_params(
115 ::media::AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout, 119 ::media::AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
116 sample_rate, bits_per_sample, buffer_size); 120 sample_rate, bits_per_sample, buffer_size);
117 return output_params; 121 return output_params;
118 } 122 }
119 123
120 } // namespace media 124 } // namespace media
121 } // namespace chromecast 125 } // namespace chromecast
OLDNEW
« no previous file with comments | « chromecast/media/audio/cast_audio_manager.h ('k') | chromecast/media/audio/cast_audio_manager_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698