Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: runtime/vm/parser.cc

Issue 185553018: Always evaluate e in (e is T) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 33288)
+++ runtime/vm/parser.cc (working copy)
@@ -7608,11 +7608,14 @@
if (((op_kind == Token::kIS) || (op_kind == Token::kISNOT) ||
(op_kind == Token::kAS)) &&
type.IsMalformedOrMalbounded()) {
- // Note that a type error is thrown even if the tested value is null
- // in a type test or in a type cast.
- // TODO(hausner): We drop the left operand. We need to
- // evaluate it in case there are side effects.
- left_operand = ThrowTypeError(type_pos, type);
+ // Note that a type error is thrown in a type test or in
+ // a type cast even if the tested value is null.
+ // We need to evaluate the left operand for potential
+ // side effects.
+ LetNode* let = new LetNode(left_operand->token_pos());
+ let->AddNode(left_operand);
+ let->AddNode(ThrowTypeError(type_pos, type));
+ left_operand = let;
break; // Type checks and casts can't be chained.
}
}
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698