Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 185553002: Don't try to upload symbols for msvcr120 and msvcp120 (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M scripts/common/archive_utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scottmg
6 years, 9 months ago (2014-03-02 16:32:32 UTC) #1
scottmg
(please cq if anyone thinks it looks ok)
6 years, 9 months ago (2014-03-02 16:56:16 UTC) #2
kareng
On 2014/03/02 16:56:16, scottmg wrote: > (please cq if anyone thinks it looks ok) LGTM
6 years, 9 months ago (2014-03-02 16:59:43 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 9 months ago (2014-03-02 17:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/185553002/1
6 years, 9 months ago (2014-03-02 17:00:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-02 17:01:18 UTC) #6
commit-bot: I haz the power
Presubmit check for 185553002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 9 months ago (2014-03-02 17:01:19 UTC) #7
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 9 months ago (2014-03-02 17:01:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/185553002/1
6 years, 9 months ago (2014-03-02 17:02:01 UTC) #9
commit-bot: I haz the power
Change committed as 254406
6 years, 9 months ago (2014-03-02 17:03:04 UTC) #10
robertshield
6 years, 9 months ago (2014-03-02 17:05:55 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698