Mac: Update the tooltip view tooltip when a tab's title changes.

Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.

Committed: https://crrev.com/cad10375b43638e45bb4e7630e71313b59a13842
Cr-Commit-Position: refs/heads/master@{#387840}

[tapted, 2016-04-01 18:30:11]

Description was changed from

==========
Mac: Update the tooltip view tooltip when the title changes

BUG=599401
==========

to

==========
Mac: Update the tooltip view tooltip when the title changes

Currently only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

[tapted, 2016-04-01 18:30:12]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[tapted, 2016-04-01 18:30:36]

Description was changed from

==========
Mac: Update the tooltip view tooltip when the title changes

Currently only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

to

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

[tapted, 2016-04-01 18:31:58]

Description was changed from

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

to

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

Currently only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

[tapted, 2016-04-01 19:22:03]

HI Robert, PTAL

[tapted, 2016-04-01 19:22:54]

Description was changed from

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

Currently only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

to

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

[Robert Sesek, 2016-04-01 19:57:08]

How much work would it be to write a unittest for this? (Otherwise LGTM)

[Robert Sesek, 2016-04-01 19:57:10]

How much work would it be to write a unittest for this? (Otherwise LGTM)

[tapted, 2016-04-01 21:50:35]

PTAL

On 2016/04/01 19:57:10, Robert Sesek wrote:
> How much work would it be to write a unittest for this? (Otherwise LGTM)

*Points to Patchset 4* This much. Assuming the bots like it as much as my
macbook.

Except there was one weird thing with the TabStripControllerDragBlockingView.
Which is still a thing, but maybe shouldn't be. It kicks in if you click between
the New Tab button and the last tab to start dragging the window. That starts a
special drag loop which doesn't let you drag the window to other desktops, but
otherwise seems OK. It was added in https://codereview.chromium.org/174461

https://codereview.chromium.org/1855503002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm (right):

https://codereview.chromium.org/1855503002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm:319:
EXPECT_NSEQ(toolTipText, [toolTipView toolTip]);
Verified this fails without the fix, with

../../chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm:319: Failure
Value of: [toolTipView toolTip]
  Actual: Untitled
Expected: toolTipText
Which is: Untitled
This tab's content is being shared.

[Robert Sesek, 2016-04-04 14:59:46]

LGTM

[Robert Sesek, 2016-04-15 21:22:26]

CQ this?

[tapted, 2016-04-18 00:22:28]

On 2016/04/15 21:22:26, Robert Sesek wrote:
> CQ this?

Bwah. Sorry - jetlag unmapped this from my brainqueue. And I wanted to mash
around a few more test cases with the relativeTo:dragBlockingView_ change. Which
I just did - and I can't see any behavioural changes from that, so I think it's
all good to go \o/

[tapted, 2016-04-18 00:22:35]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-04-18 00:22:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855503002/60001

[commit-bot: I haz the power, 2016-04-18 01:14:56]

Description was changed from

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

to

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

[commit-bot: I haz the power, 2016-04-18 01:14:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-18 01:16:30]

Description was changed from

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.
==========

to

==========
Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG=599401
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.

Committed: https://crrev.com/cad10375b43638e45bb4e7630e71313b59a13842
Cr-Commit-Position: refs/heads/master@{#387840}
==========

[commit-bot: I haz the power, 2016-04-18 01:16:31]

Patchset 4 (id:??) landed as
https://crrev.com/cad10375b43638e45bb4e7630e71313b59a13842
Cr-Commit-Position: refs/heads/master@{#387840}