Mac: Update the tooltip view tooltip when a tab's title changes.

chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/bind_helpers.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "chrome/browser/media/media_stream_capture_indicator.h"
@@ skipping 262 matching lines @@
 
 TEST_F(TabStripControllerTest, CorrectTitleAndToolTipTextFromSetTabTitle) {
   using content::MediaStreamDevice;
   using content::MediaStreamDevices;
   using content::MediaStreamUI;
 
   TabView* const tab = CreateTab();
   TabController* const tabController = [tab controller];
   WebContents* const contents = model_->GetActiveWebContents();
 
+  // For the duration of the test, assume the tab has been hovered. This adds a
+  // subview containing the actual source of the tooltip.
+  [controller_ setHoveredTab:tab];
+  // Note -[NSView hitTest:] takes superview coordinates. Then, find a spot that
+  // is outside the mask image, but inside the tab.
+  NSPoint centerPoint = NSMakePoint(5, NSMidY([tab bounds]));
+  NSPoint hitPoint = [tab convertPoint:centerPoint
+                                toView:[tab_strip_ superview]];
+  NSView* toolTipView = [tab_strip_ hitTest:hitPoint];
+  EXPECT_TRUE(toolTipView);
+  EXPECT_NE(toolTipView, tab);
+
   // Initially, tab title and tooltip text are equivalent.
   EXPECT_EQ(TabAlertState::NONE,
             chrome::GetTabAlertStateForContents(contents));
   [controller_ setTabTitle:tabController withContents:contents];
   NSString* const baseTitle = [tabController title];
   EXPECT_NSEQ(baseTitle, [tabController toolTip]);
+  EXPECT_NSEQ([tabController toolTip], [toolTipView toolTip]);
 
   // Simulate the start of tab video capture.  Tab title remains the same, but
   // the tooltip text should include the following appended: 1) a line break;
   // 2) a non-empty string with a localized description of the alert state.
   scoped_refptr<MediaStreamCaptureIndicator> indicator =
       MediaCaptureDevicesDispatcher::GetInstance()->
           GetMediaStreamCaptureIndicator();
   const MediaStreamDevice dummyVideoCaptureDevice(
       content::MEDIA_TAB_VIDEO_CAPTURE, "dummy_id", "dummy name");
   scoped_ptr<MediaStreamUI> streamUi(indicator->RegisterMediaStream(
       contents, MediaStreamDevices(1, dummyVideoCaptureDevice)));
   streamUi->OnStarted(base::Bind(&base::DoNothing));
   EXPECT_EQ(TabAlertState::TAB_CAPTURING,
             chrome::GetTabAlertStateForContents(contents));
   [controller_ setTabTitle:tabController withContents:contents];
   EXPECT_NSEQ(baseTitle, [tabController title]);
   NSString* const toolTipText = [tabController toolTip];
+  EXPECT_NSEQ(toolTipText, [toolTipView toolTip]);

[tapted, 2016/04/01 21:50:35]

Verified this fails without the fix, with

../../chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm:319: Failure
Value of: [toolTipView toolTip]
  Actual: Untitled
Expected: toolTipText
Which is: Untitled
This tab's content is being shared.

   if ([baseTitle length] > 0) {
     EXPECT_TRUE(NSEqualRanges(NSMakeRange(0, [baseTitle length]),
                               [toolTipText rangeOfString:baseTitle]));
     EXPECT_TRUE(NSEqualRanges(NSMakeRange([baseTitle length], 1),
                               [toolTipText rangeOfString:@"\n"]));
     EXPECT_LT([baseTitle length] + 1, [toolTipText length]);
   } else {
     EXPECT_LT(0u, [toolTipText length]);
   }
 
   // Simulate the end of tab video capture.  Tab title and tooltip should become
   // equivalent again.
   streamUi.reset();
   EXPECT_EQ(TabAlertState::NONE,
             chrome::GetTabAlertStateForContents(contents));
   [controller_ setTabTitle:tabController withContents:contents];
   EXPECT_NSEQ(baseTitle, [tabController title]);
   EXPECT_NSEQ(baseTitle, [tabController toolTip]);
+  EXPECT_NSEQ(baseTitle, [toolTipView toolTip]);
 }
 
 TEST_F(TabStripControllerTest, TabCloseDuringDrag) {
   TabController* tab;
   // The TabController gets autoreleased when created, but is owned by the
   // tab strip model. Use a ScopedNSAutoreleasePool to get a truly weak ref
   // to it to test that -maybeStartDrag:forTab: can handle that properly.
   {
     base::mac::ScopedNSAutoreleasePool pool;
     tab = [CreateTab() controller];
@@ skipping 127 matching lines @@
   [tabStripControllerForTesting setAlertStateForContents:contents_at_tab0
                                           withAlertState:TabAlertState::NONE];
   [controller_ updateWindowAlertState:TabAlertState::NONE
                        forWebContents:contents_at_tab0];
   // Neither of tabs playing nor muting, so the window alert state should be
   // NONE.
   EXPECT_EQ(TabAlertState::NONE, [window_controller alertState]);
 }
 
 }  // namespace